From: Hui Liu <[email protected]>
Add definition for three LEDs to make sure they can
be enabled base on QCOM LPG LED driver.
Signed-off-by: Hui Liu <[email protected]>
---
Changes in v3:
- Rephrased commit text and updated the nodes to qcm6490-idp board file.
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Rephrased commit text and updated the nodes to board file.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 37c91fdf3ab9..f801144a1556 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -5,6 +5,7 @@
/dts-v1/;
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sc7280.dtsi"
#include "pm7325.dtsi"
@@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
};
};
+&pm8350c_pwm {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ label = "red";
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ label = "green";
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ label = "blue";
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
---
base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
change-id: 20231215-lpg-4aadd374811a
Best regards,
--
Hui Liu <[email protected]>
On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay
<[email protected]> wrote:
>
> From: Hui Liu <[email protected]>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <[email protected]>
> ---
> Changes in v3:
> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
The commit message is the same as in v2.
Commit subject mentions non-existing board, "qcs6490-idp"
> - Link to v2: https://lore.kernel.org/all/[email protected]/
>
> Changes in v2:
> - Rephrased commit text and updated the nodes to board file.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 37c91fdf3ab9..f801144a1556 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -5,6 +5,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sc7280.dtsi"
> #include "pm7325.dtsi"
> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
> };
> };
>
> +&pm8350c_pwm {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_RED>;
> + label = "red";
Is there any reason why Krzysztof's review for v2 was ignored? Let me
repeat it here: "Drop labels. You already have color, so you miss
function."
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_GREEN>;
> + label = "green";
> + };
> +
> + led@3 {
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + label = "blue";
> + };
> +};
> +
> &qupv3_id_0 {
> status = "okay";
> };
>
> ---
> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
> change-id: 20231215-lpg-4aadd374811a
>
> Best regards,
> --
> Hui Liu <[email protected]>
>
>
--
With best wishes
Dmitry
On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote:
> From: Hui Liu <[email protected]>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <[email protected]>
> ---
> Changes in v3:
> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
> - Link to v2: https://lore.kernel.org/all/[email protected]/
>
> Changes in v2:
> - Rephrased commit text and updated the nodes to board file.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 37c91fdf3ab9..f801144a1556 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -5,6 +5,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sc7280.dtsi"
> #include "pm7325.dtsi"
> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
> };
> };
>
> +&pm8350c_pwm {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + led@1 {
> + reg = <1>;
Hi Hui Liu,
> + color = <LED_COLOR_ID_RED>;
> + label = "red";
Please remove the deprecated "label" property. Since you already have
"color" set you only need to add "function". On phones for the
notification LED we usually use "function = LED_FUNCTION_STATUS;"
Also depends on what your hardware looks like, if it's 3 separate LEDs
then with label replaced it would be okay.
If the 3 LEDs are in one spot (so you can mix the colors with it), then
please make it a RGB multi-led like e.g. in sm8550-qrd.dts.
Regards
Luca
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_GREEN>;
> + label = "green";
> + };
> +
> + led@3 {
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + label = "blue";
> + };
> +};
> +
> &qupv3_id_0 {
> status = "okay";
> };
>
> ---
> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
> change-id: 20231215-lpg-4aadd374811a
>
> Best regards,
On 11/01/2024 09:47, Luca Weiss wrote:
> On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote:
>> From: Hui Liu <[email protected]>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <[email protected]>
>> ---
>> Changes in v3:
>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>> - Link to v2: https://lore.kernel.org/all/[email protected]/
>>
>> Changes in v2:
>> - Rephrased commit text and updated the nodes to board file.
>> - Link to v1: https://lore.kernel.org/r/[email protected]
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 37c91fdf3ab9..f801144a1556 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -5,6 +5,7 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> #include "sc7280.dtsi"
>> #include "pm7325.dtsi"
>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
>> };
>> };
>>
>> +&pm8350c_pwm {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + led@1 {
>> + reg = <1>;
>
> Hi Hui Liu,
>
>> + color = <LED_COLOR_ID_RED>;
>> + label = "red";
>
> Please remove the deprecated "label" property. Since you already have
> "color" set you only need to add "function". On phones for the
> notification LED we usually use "function = LED_FUNCTION_STATUS;"
>
> Also depends on what your hardware looks like, if it's 3 separate LEDs
> then with label replaced it would be okay.
> If the 3 LEDs are in one spot (so you can mix the colors with it), then
> please make it a RGB multi-led like e.g. in sm8550-qrd.dts.
>
I already asked for this and it was ignored:
https://lore.kernel.org/all/[email protected]/
Let's engage three different community reviewers to repeat the same, one
feedback. This is just disrespectful to our time.
Best regards,
Krzysztof
On 1/11/2024 4:58 PM, Krzysztof Kozlowski wrote:
> On 11/01/2024 09:47, Luca Weiss wrote:
>> On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote:
>>> From: Hui Liu <[email protected]>
>>>
>>> Add definition for three LEDs to make sure they can
>>> be enabled base on QCOM LPG LED driver.
>>>
>>> Signed-off-by: Hui Liu <[email protected]>
>>> ---
>>> Changes in v3:
>>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>>> - Link to v2: https://lore.kernel.org/all/[email protected]/
>>>
>>> Changes in v2:
>>> - Rephrased commit text and updated the nodes to board file.
>>> - Link to v1: https://lore.kernel.org/r/[email protected]
>>> ---
>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
>>> 1 file changed, 25 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> index 37c91fdf3ab9..f801144a1556 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> @@ -5,6 +5,7 @@
>>>
>>> /dts-v1/;
>>>
>>> +#include <dt-bindings/leds/common.h>
>>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>> #include "sc7280.dtsi"
>>> #include "pm7325.dtsi"
>>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
>>> };
>>> };
>>>
>>> +&pm8350c_pwm {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + status = "okay";
>>> +
>>> + led@1 {
>>> + reg = <1>;
>>
>> Hi Hui Liu,
>>
>>> + color = <LED_COLOR_ID_RED>;
>>> + label = "red";
>>
>> Please remove the deprecated "label" property. Since you already have
>> "color" set you only need to add "function". On phones for the
>> notification LED we usually use "function = LED_FUNCTION_STATUS;"
>>
>> Also depends on what your hardware looks like, if it's 3 separate LEDs
>> then with label replaced it would be okay.
>> If the 3 LEDs are in one spot (so you can mix the colors with it), then
>> please make it a RGB multi-led like e.g. in sm8550-qrd.dts.
>>
>
> I already asked for this and it was ignored:
>
> https://lore.kernel.org/all/[email protected]/
>
> Let's engage three different community reviewers to repeat the same, one
> feedback. This is just disrespectful to our time.
Sorry, I ignored that comments, I will submit v4 to update it. Thanks
for your comments.
>
> Best regards,
> Krzysztof
>
On 1/11/2024 4:47 PM, Luca Weiss wrote:
> On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote:
>> From: Hui Liu <[email protected]>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <[email protected]>
>> ---
>> Changes in v3:
>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>> - Link to v2: https://lore.kernel.org/all/[email protected]/
>>
>> Changes in v2:
>> - Rephrased commit text and updated the nodes to board file.
>> - Link to v1: https://lore.kernel.org/r/[email protected]
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 37c91fdf3ab9..f801144a1556 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -5,6 +5,7 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> #include "sc7280.dtsi"
>> #include "pm7325.dtsi"
>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
>> };
>> };
>>
>> +&pm8350c_pwm {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + led@1 {
>> + reg = <1>;
>
> Hi Hui Liu,
>
>> + color = <LED_COLOR_ID_RED>;
>> + label = "red";
>
> Please remove the deprecated "label" property. Since you already have
> "color" set you only need to add "function". On phones for the
> notification LED we usually use "function = LED_FUNCTION_STATUS;"
>
I will remove it at next version, thanks!
> Also depends on what your hardware looks like, if it's 3 separate LEDs
> then with label replaced it would be okay.
> If the 3 LEDs are in one spot (so you can mix the colors with it), then
> please make it a RGB multi-led like e.g. in sm8550-qrd.dts
The 3 LEDs are separate.
> Regards
> Luca
>
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + label = "green";
>> + };
>> +
>> + led@3 {
>> + reg = <3>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + label = "blue";
>> + };
>> +};
>> +
>> &qupv3_id_0 {
>> status = "okay";
>> };
>>
>> ---
>> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
>> change-id: 20231215-lpg-4aadd374811a
>>
>> Best regards,
>
On 1/11/2024 11:38 AM, Dmitry Baryshkov wrote:
> On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay
> <[email protected]> wrote:
>>
>> From: Hui Liu <[email protected]>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <[email protected]>
>> ---
>> Changes in v3:
>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>
> The commit message is the same as in v2.
>
> Commit subject mentions non-existing board, "qcs6490-idp"
>
>> - Link to v2: https://lore.kernel.org/all/[email protected]/
>>
>> Changes in v2:
>> - Rephrased commit text and updated the nodes to board file.
>> - Link to v1: https://lore.kernel.org/r/[email protected]
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 37c91fdf3ab9..f801144a1556 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -5,6 +5,7 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> #include "sc7280.dtsi"
>> #include "pm7325.dtsi"
>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
>> };
>> };
>>
>> +&pm8350c_pwm {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + led@1 {
>> + reg = <1>;
>> + color = <LED_COLOR_ID_RED>;
>> + label = "red";
>
> Is there any reason why Krzysztof's review for v2 was ignored? Let me
> repeat it here: "Drop labels. You already have color, so you miss
> function."
I will update it.
>
>
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + label = "green";
>> + };
>> +
>> + led@3 {
>> + reg = <3>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + label = "blue";
>> + };
>> +};
>> +
>> &qupv3_id_0 {
>> status = "okay";
>> };
>>
>> ---
>> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
>> change-id: 20231215-lpg-4aadd374811a
>>
>> Best regards,
>> --
>> Hui Liu <[email protected]>
>>
>>
>
>
On 1/11/2024 11:38 AM, Dmitry Baryshkov wrote:
> On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay
> <[email protected]> wrote:
>>
>> From: Hui Liu <[email protected]>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <[email protected]>
>> ---
>> Changes in v3:
>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>
> The commit message is the same as in v2.
>
> Commit subject mentions non-existing board, "qcs6490-idp"
This devicetree file of this board has been merged in linux-next,
https://lore.kernel.org/linux-arm-msm/[email protected]/
>
>> - Link to v2: https://lore.kernel.org/all/[email protected]/
>>
>> Changes in v2:
>> - Rephrased commit text and updated the nodes to board file.
>> - Link to v1: https://lore.kernel.org/r/[email protected]
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 37c91fdf3ab9..f801144a1556 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -5,6 +5,7 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> #include "sc7280.dtsi"
>> #include "pm7325.dtsi"
>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
>> };
>> };
>>
>> +&pm8350c_pwm {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + led@1 {
>> + reg = <1>;
>> + color = <LED_COLOR_ID_RED>;
>> + label = "red";
>
> Is there any reason why Krzysztof's review for v2 was ignored? Let me
> repeat it here: "Drop labels. You already have color, so you miss
> function."
>
>
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + label = "green";
>> + };
>> +
>> + led@3 {
>> + reg = <3>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + label = "blue";
>> + };
>> +};
>> +
>> &qupv3_id_0 {
>> status = "okay";
>> };
>>
>> ---
>> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
>> change-id: 20231215-lpg-4aadd374811a
>>
>> Best regards,
>> --
>> Hui Liu <[email protected]>
>>
>>
>
>