2024-01-11 13:44:11

by Geert Uytterhoeven

Subject: [PATCH] of: unittest: Fix of_count_phandle_with_args() expected value message

The expected result value for the call to of_count_phandle_with_args()
was updated from 7 to 8, but the accompanying error message was
forgotten.

Fixes: 4dde83569832f937 ("of: Fix double free in of_parse_phandle_with_args_map")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/of/unittest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 45bd0d28c7173db9..cfd60e35a8992d7d 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -574,7 +574,7 @@ static void __init of_unittest_parse_phandle_with_args_map(void)
}

rc = of_count_phandle_with_args(np, "phandle-list", "#phandle-cells");
- unittest(rc == 8, "of_count_phandle_with_args() returned %i, expected 7\n", rc);
+ unittest(rc == 8, "of_count_phandle_with_args() returned %i, expected 8\n", rc);

for (i = 0; i < 9; i++) {
bool passed = true;
--
2.34.1

2024-01-11 22:18:20

by Rob Herring (Arm)

Subject: Re: [PATCH] of: unittest: Fix of_count_phandle_with_args() expected value message

On Thu, 11 Jan 2024 09:50:25 +0100, Geert Uytterhoeven wrote:
> The expected result value for the call to of_count_phandle_with_args()
> was updated from 7 to 8, but the accompanying error message was
> forgotten.
>
> Fixes: 4dde83569832f937 ("of: Fix double free in of_parse_phandle_with_args_map")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/of/unittest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!