2024-01-11 18:14:23

by Ninad Palsule

[permalink] [raw]
Subject: [PATCH v3 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc

Document the new compatibles used on IBM system1-bmc

Signed-off-by: Ninad Palsule <[email protected]>
---
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 68f717670f78..093b28f4ecba 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -82,6 +82,7 @@ properties:
- facebook,yosemite4-bmc
- ibm,everest-bmc
- ibm,rainier-bmc
+ - ibm,system1-bmc
- ibm,tacoma-bmc
- inventec,starscream-bmc
- inventec,transformer-bmc
--
2.39.2



2024-01-11 19:41:07

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc

On 11/01/2024 19:12, Ninad Palsule wrote:
> Document the new compatibles used on IBM system1-bmc
>
> Signed-off-by: Ninad Palsule <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> 1 file changed, 1 insertion(+)

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof


2024-01-11 19:50:41

by Ninad Palsule

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc

Hi Krzysztof,

On 1/11/24 13:40, Krzysztof Kozlowski wrote:
> On 11/01/2024 19:12, Ninad Palsule wrote:
>> Document the new compatibles used on IBM system1-bmc
>>
>> Signed-off-by: Ninad Palsule <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>> 1 file changed, 1 insertion(+)
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.

This is a mistake from my side. Sorry about that. I will remember it
next time.

Thanks & Regards,

Ninad