This patch series adds support for BCM74165 to the brcmstb_gisb.c driver
since new offsets have been introduced which requires the driver to be
aware of them.
Florian Fainelli (2):
dt-bindings: bus: Document Broadcom GISB arbiter 74165 compatible
bus: brcmstb_gisb: Added support for 74165 register layout
.../devicetree/bindings/bus/brcm,gisb-arb.yaml | 1 +
drivers/bus/brcmstb_gisb.c | 15 +++++++++++++++
2 files changed, 16 insertions(+)
--
2.34.1
The 74165 chip introduces a new layout for the GISB arbiter which is not
identical to previous chips, document the new compatible that we are
going to key off.
Signed-off-by: Florian Fainelli <[email protected]>
---
Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
index 3aaefdbe361e..9017c5a3f3d2 100644
--- a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
+++ b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
@@ -18,6 +18,7 @@ properties:
- const: brcm,gisb-arb
- items:
- enum:
+ - brcm,bcm74165-gisb-arb # for V7 new style 16nm chips
- brcm,bcm7278-gisb-arb # for V7 28nm chips
- brcm,bcm7435-gisb-arb # for newer 40nm chips
- brcm,bcm7400-gisb-arb # for older 40nm chips and all 65nm chips
--
2.34.1
BCM74165 introduces a new register layout which is different from
previously taped out chips, match the documented compatible and use the
appropriate table of register offsets.
Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/bus/brcmstb_gisb.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index b6dfe4340da2..65ae758f3194 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -96,6 +96,20 @@ static const int gisb_offsets_bcm7400[] = {
[ARB_ERR_CAP_MASTER] = 0x0d8,
};
+static const int gisb_offsets_bcm74165[] = {
+ [ARB_TIMER] = 0x008,
+ [ARB_BP_CAP_CLR] = 0x044,
+ [ARB_BP_CAP_HI_ADDR] = -1,
+ [ARB_BP_CAP_ADDR] = 0x048,
+ [ARB_BP_CAP_STATUS] = 0x058,
+ [ARB_BP_CAP_MASTER] = 0x05c,
+ [ARB_ERR_CAP_CLR] = 0x038,
+ [ARB_ERR_CAP_HI_ADDR] = -1,
+ [ARB_ERR_CAP_ADDR] = 0x020,
+ [ARB_ERR_CAP_STATUS] = 0x030,
+ [ARB_ERR_CAP_MASTER] = 0x034,
+};
+
static const int gisb_offsets_bcm7435[] = {
[ARB_TIMER] = 0x00c,
[ARB_BP_CAP_CLR] = 0x014,
@@ -393,6 +407,7 @@ static const struct of_device_id brcmstb_gisb_arb_of_match[] = {
{ .compatible = "brcm,bcm7400-gisb-arb", .data = gisb_offsets_bcm7400 },
{ .compatible = "brcm,bcm7278-gisb-arb", .data = gisb_offsets_bcm7278 },
{ .compatible = "brcm,bcm7038-gisb-arb", .data = gisb_offsets_bcm7038 },
+ { .compatible = "brcm,bcm74165-gisb-arb", .data = gisb_offsets_bcm74165 },
{ },
};
--
2.34.1
On 12/01/2024 00:15, Florian Fainelli wrote:
> The 74165 chip introduces a new layout for the GISB arbiter which is not
> identical to previous chips, document the new compatible that we are
> going to key off.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
From: Florian Fainelli <[email protected]>
On Thu, 11 Jan 2024 15:15:38 -0800, Florian Fainelli <[email protected]> wrote:
> The 74165 chip introduces a new layout for the GISB arbiter which is not
> identical to previous chips, document the new compatible that we are
> going to key off.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian
From: Florian Fainelli <[email protected]>
On Thu, 11 Jan 2024 15:15:39 -0800, Florian Fainelli <[email protected]> wrote:
> BCM74165 introduces a new register layout which is different from
> previously taped out chips, match the documented compatible and use the
> appropriate table of register offsets.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian