2024-01-10 16:17:59

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: hmc425a: add conditional GPIO array size constraints

On Wed, Jan 10, 2024 at 05:37:09PM +0200, Dumitru Ceclan wrote:
> ADRF5740 and HMC540S have a 4 bit parallel interface.
> Update ctr-gpios description and min/maxItems values depending on the
> matched compatible to correctly reflect the hardware properties.
>
> Signed-off-by: Dumitru Ceclan <[email protected]>

Seems like you need a Fixes: tag, since the original binding was wrong?

> ---
> .../bindings/iio/amplifiers/adi,hmc425a.yaml | 33 +++++++++++++++++--
> 1 file changed, 30 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> index 67de9d4e3a1d..a434cb8ddcc9 100644
> --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> @@ -33,11 +33,38 @@ properties:
>
> ctrl-gpios:
> description:
> - Must contain an array of 6 GPIO specifiers, referring to the GPIO pins
> - connected to the control pins V1-V6.
> - minItems: 6
> + Must contain an array of GPIO specifiers, referring to the GPIO pins
> + connected to the control pins.
> + ADRF5740 - 4 GPIO connected to D2-D5
> + HMC540S - 4 GPIO connected to V1-V4
> + HMC425A - 6 GPIO connected to V1-V6
> + minItems: 1
> maxItems: 6
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: adi,hmc425a
> + then:
> + properties:
> + ctrl-gpios:
> + minItems: 6

> + maxItems: 6

This one should not be needed, it's already set by constraints on the
property above.

Acked-by: Conor Dooley <[email protected]>

> + - if:
> + properties:
> + compatible:
> + contains:
> + anyOf:
> + - const: adi,adrf5740
> + - const: adi,hmc540s
> + then:
> + properties:
> + ctrl-gpios:
> + minItems: 4
> + maxItems: 4

I'd say this should be an else, but that clearly would just be churn
since your next patch adds something with a different set of
constraints.

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

> +
> required:
> - compatible
> - ctrl-gpios
> --
> 2.42.0
>


Attachments:
(No filename) (2.36 kB)
signature.asc (235.00 B)
Download all attachments

2024-01-13 15:36:58

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: hmc425a: add conditional GPIO array size constraints

On Wed, 10 Jan 2024 16:17:45 +0000
Conor Dooley <[email protected]> wrote:

> On Wed, Jan 10, 2024 at 05:37:09PM +0200, Dumitru Ceclan wrote:
> > ADRF5740 and HMC540S have a 4 bit parallel interface.
> > Update ctr-gpios description and min/maxItems values depending on the
> > matched compatible to correctly reflect the hardware properties.
> >
> > Signed-off-by: Dumitru Ceclan <[email protected]>
>
> Seems like you need a Fixes: tag, since the original binding was wrong?
If you aren't doing a v3 as nothing else to change then just replying with
an appropriate fixes tag to this email is fine as b4 will work it's magic
when I pull the patches off the archive.

Thanks,

Jonathan