2024-01-14 05:28:04

by Randy Dunlap

Subject: [PATCH] ARM: s5pv210: fix pm.c kernel-doc warning

Use the correct function name in the kernel-doc comment to prevent
a kernel-doc warning:

arch/arm/mach-s5pv210/pm.c:61: warning: expecting prototype for s3c_pm_do_restore(). Prototype was for s3c_pm_do_restore_core() instead

Signed-off-by: Randy Dunlap <[email protected]>
Cc: [email protected]
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Alim Akhtar <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
KernelVersion: 0dd3ee31125508cd67f7e717

arch/arm/mach-s5pv210/pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/arch/arm/mach-s5pv210/pm.c b/arch/arm/mach-s5pv210/pm.c
--- a/arch/arm/mach-s5pv210/pm.c
+++ b/arch/arm/mach-s5pv210/pm.c
@@ -47,7 +47,7 @@ static void s3c_pm_do_save(struct sleep_
}

/**
- * s3c_pm_do_restore() - restore register values from the save list.
+ * s3c_pm_do_restore_core() - restore register values from the save list.
* @ptr: Pointer to an array of registers.
* @count: Size of the ptr array.
*

2024-01-22 10:43:54

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: s5pv210: fix pm.c kernel-doc warning

On 14/01/2024 06:27, Randy Dunlap wrote:
> Use the correct function name in the kernel-doc comment to prevent
> a kernel-doc warning:
>
> arch/arm/mach-s5pv210/pm.c:61: warning: expecting prototype for s3c_pm_do_restore(). Prototype was for s3c_pm_do_restore_core() instead
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Alim Akhtar <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Several checkpatch warnings:
WARNING: Use a single space after Cc:
#12:
Cc: <[email protected]>

WARNING: Use a single space after Cc:
#15:
Cc: <[email protected]>

WARNING: Use a single space after Cc:
#16:
Cc: <[email protected]>


Fixed and applied.

ount: Size of the ptr array.
> *

Best regards,
Krzysztof

2024-01-22 10:45:09

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: s5pv210: fix pm.c kernel-doc warning

On Sat, 13 Jan 2024 21:27:51 -0800, Randy Dunlap wrote:
> Use the correct function name in the kernel-doc comment to prevent
> a kernel-doc warning:
>
> arch/arm/mach-s5pv210/pm.c:61: warning: expecting prototype for s3c_pm_do_restore(). Prototype was for s3c_pm_do_restore_core() instead
>
>

Applied, thanks!

[1/1] ARM: s5pv210: fix pm.c kernel-doc warning
https://git.kernel.org/krzk/linux/c/52524ff0558b57e8b78d05d645456b0a77c787bf

Best regards,
--
Krzysztof Kozlowski <[email protected]>