2024-01-15 01:01:33

by Randy Dunlap

Subject: [PATCH] thermal: db8500: remove kernel-doc notation from data

Don't mark data with a "/**" comment. kernel-doc does not support
documenting data definitions. This change prevents a kernel-doc
warning.

db8500_thermal.c:27: warning: cannot understand function prototype: 'const unsigned long db8500_thermal_points[] = '

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Hongbo Zhang <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Zhang Rui <[email protected]>
Cc: Lukasz Luba <[email protected]>
Cc: [email protected]
---
drivers/thermal/db8500_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
--- a/drivers/thermal/db8500_thermal.c
+++ b/drivers/thermal/db8500_thermal.c
@@ -20,7 +20,7 @@
#define PRCMU_DEFAULT_MEASURE_TIME 0xFFF
#define PRCMU_DEFAULT_LOW_TEMP 0

-/**
+/*
* db8500_thermal_points - the interpolation points that trigger
* interrupts
*/

2024-01-15 08:07:02

by Linus Walleij

Subject: Re: [PATCH] thermal: db8500: remove kernel-doc notation from data

On Mon, Jan 15, 2024 at 2:01 AM Randy Dunlap <[email protected]> wrote:

> Don't mark data with a "/**" comment. kernel-doc does not support
> documenting data definitions. This change prevents a kernel-doc
> warning.
>
> db8500_thermal.c:27: warning: cannot understand function prototype: 'const unsigned long db8500_thermal_points[] = '
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Hongbo Zhang <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Daniel Lezcano <[email protected]>
> Cc: Zhang Rui <[email protected]>
> Cc: Lukasz Luba <[email protected]>
> Cc: [email protected]

Fair enough,
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij