2024-01-15 05:05:18

by Randy Dunlap

Subject: [PATCH] coresight: etm3x: add a kernel-doc "blank line"

Change an empty line inside of kernel-doc to a " *" (kernel-doc
blank line) to prevent a kernel-doc warning:

drivers/hwtracing/coresight/coresight-etm3x-core.c:118: warning: bad line:

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Pratik Patel <[email protected]>
Cc: Mathieu Poirier <[email protected]>
Cc: Suzuki K Poulose <[email protected]>
Cc: Mike Leach <[email protected]>
Cc: James Clark <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/hwtracing/coresight/coresight-etm3x-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c
--- a/drivers/hwtracing/coresight/coresight-etm3x-core.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c
@@ -115,7 +115,7 @@ static void etm_clr_pwrup(struct etm_drv
*
* Basically the same as @coresight_timeout except for the register access
* method where we have to account for CP14 configurations.
-
+ *
* Return: 0 as soon as the bit has taken the desired state or -EAGAIN if
* TIMEOUT_US has elapsed, which ever happens first.
*/

2024-01-15 10:01:28

by James Clark

Subject: Re: [PATCH] coresight: etm3x: add a kernel-doc "blank line"

On 15/01/2024 05:05, Randy Dunlap wrote:
> Change an empty line inside of kernel-doc to a " *" (kernel-doc
> blank line) to prevent a kernel-doc warning:
>
> drivers/hwtracing/coresight/coresight-etm3x-core.c:118: warning: bad line:
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Pratik Patel <[email protected]>
> Cc: Mathieu Poirier <[email protected]>
> Cc: Suzuki K Poulose <[email protected]>
> Cc: Mike Leach <[email protected]>
> Cc: James Clark <[email protected]>
> Cc: Alexander Shishkin <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/hwtracing/coresight/coresight-etm3x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> @@ -115,7 +115,7 @@ static void etm_clr_pwrup(struct etm_drv
> *
> * Basically the same as @coresight_timeout except for the register access
> * method where we have to account for CP14 configurations.
> -
> + *
> * Return: 0 as soon as the bit has taken the desired state or -EAGAIN if
> * TIMEOUT_US has elapsed, which ever happens first.
> */

Duplicate of
https://lore.kernel.org/linux-arm-kernel/[email protected]/
which should appear in coresight-next soon. But either way, thanks for
the fix.

James