2024-01-15 07:54:43

by Meir Elisha

Subject: [PATCH] Staging: rtl8723bs: rtw_ieee80211: Remove extra space

Fix checkpatch warning: please, no space before tabs

Signed-off-by: Meir Elisha <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index 30e7457a9c31..cfa994835008 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1036,7 +1036,7 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork)
struct HT_info_element *pht_info = NULL;
struct ieee80211_ht_cap *pht_cap = NULL;
unsigned int len;
- unsigned char *p;
+ unsigned char *p;
__le16 le_cap;

memcpy((u8 *)&le_cap, rtw_get_capability_from_ie(pnetwork->network.ies), 2);
--
2.34.1

2024-01-15 08:01:45

by Dan Carpenter

Subject: Re: [PATCH] Staging: rtl8723bs: rtw_ieee80211: Remove extra space

On Mon, Jan 15, 2024 at 09:54:25AM +0200, Meir Elisha wrote:
> Fix checkpatch warning: please, no space before tabs
>
> Signed-off-by: Meir Elisha <[email protected]>
> ---
> drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 30e7457a9c31..cfa994835008 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1036,7 +1036,7 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork)
> struct HT_info_element *pht_info = NULL;
> struct ieee80211_ht_cap *pht_cap = NULL;
> unsigned int len;
^^^^^^^^^^^
How about we delete these as well.

> - unsigned char *p;
> + unsigned char *p;
> __le16 le_cap;

regards,
dan carpenter

2024-01-15 08:27:15

by Meir Elisha

Subject: Re: [PATCH] Staging: rtl8723bs: rtw_ieee80211: Remove extra space

Sure. Thanks for your reply! sending v2 patch.

‫בתאריך יום ב׳, 15 בינו׳ 2024 ב-10:01 מאת ‪Dan Carpenter‬‏
<‪[email protected]‬‏>:‬
>
> On Mon, Jan 15, 2024 at 09:54:25AM +0200, Meir Elisha wrote:
> > Fix checkpatch warning: please, no space before tabs
> >
> > Signed-off-by: Meir Elisha <[email protected]>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > index 30e7457a9c31..cfa994835008 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > @@ -1036,7 +1036,7 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork)
> > struct HT_info_element *pht_info = NULL;
> > struct ieee80211_ht_cap *pht_cap = NULL;
> > unsigned int len;
> ^^^^^^^^^^^
> How about we delete these as well.
>
> > - unsigned char *p;
> > + unsigned char *p;
> > __le16 le_cap;
>
> regards,
> dan carpenter
>