To reduce the risk of speaker damage the PA gain needs to be limited on
machines like the Lenovo Thinkpad X13s until we have active speaker
protection in place.
Limit the gain to the current default setting provided by the UCM
configuration which most user have so far been been using (due to a bug
in the configuration files which prevented hardware volume control [1]).
Included is also a related fix for the LPASS WSA macro driver, which
was changing the digital gain setting behind the back of user space and
which can result in excessive (or too low) digital gain.
There are further Qualcomm codec driver that appear to manipulate
various gain settings, but on closer inspection this turned out to be
effectively dead code which can be removed.
Johan
[1] https://github.com/alsa-project/alsa-ucm-conf/pull/382
Johan Hovold (7):
ASoC: qcom: sc8280xp: limit speaker volumes
ASoC: codecs: lpass-wsa-macro: fix compander volume hack
ASoC: codecs: lpass-wsa-macro: drop dead mixer-path gain hack
ASoC: codecs: lpass-rx-macro: drop dead mixer-path gain hack
ASoC: codecs: wcd9335: drop dead gain hacks
ASoC: codecs: wcd934x: drop dead gain hacks
ASoC: codecs: msm8916-wcd-digital: drop dead gain hacks
sound/soc/codecs/lpass-rx-macro.c | 16 +---
sound/soc/codecs/lpass-wsa-macro.c | 19 +---
sound/soc/codecs/msm8916-wcd-digital.c | 26 +-----
sound/soc/codecs/wcd9335.c | 115 ++++---------------------
sound/soc/codecs/wcd934x.c | 102 +++++-----------------
sound/soc/qcom/sc8280xp.c | 8 +-
6 files changed, 53 insertions(+), 233 deletions(-)
--
2.41.0
The vendor driver appears to be modifying the gain settings behind the
back of user space but these hacks never made it upstream except for
some essentially dead code that reads out the (cached) gain setting and
writes it back again on DAPM events.
Drop these incomplete and pointless hacks.
Signed-off-by: Johan Hovold <[email protected]>
---
sound/soc/codecs/wcd9335.c | 115 ++++++-------------------------------
1 file changed, 18 insertions(+), 97 deletions(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 43c648efd0d9..cee17b309160 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -3028,61 +3028,6 @@ static int wcd9335_codec_enable_slim(struct snd_soc_dapm_widget *w,
return 0;
}
-static int wcd9335_codec_enable_mix_path(struct snd_soc_dapm_widget *w,
- struct snd_kcontrol *kc, int event)
-{
- struct snd_soc_component *comp = snd_soc_dapm_to_component(w->dapm);
- u16 gain_reg;
- int offset_val = 0;
- int val = 0;
-
- switch (w->reg) {
- case WCD9335_CDC_RX0_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX0_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX1_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX1_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX2_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX2_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX3_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX3_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX4_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX4_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX5_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX5_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX6_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX6_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX7_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX7_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX8_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX8_RX_VOL_MIX_CTL;
- break;
- default:
- dev_err(comp->dev, "%s: No gain register avail for %s\n",
- __func__, w->name);
- return 0;
- }
-
- switch (event) {
- case SND_SOC_DAPM_POST_PMU:
- val = snd_soc_component_read(comp, gain_reg);
- val += offset_val;
- snd_soc_component_write(comp, gain_reg, val);
- break;
- case SND_SOC_DAPM_POST_PMD:
- break;
- }
-
- return 0;
-}
-
static u16 wcd9335_interp_get_primary_reg(u16 reg, u16 *ind)
{
u16 prim_int_reg = WCD9335_CDC_RX0_RX_PATH_CTL;
@@ -3291,38 +3236,26 @@ static int wcd9335_codec_enable_interpolator(struct snd_soc_dapm_widget *w,
struct snd_kcontrol *kc, int event)
{
struct snd_soc_component *comp = snd_soc_dapm_to_component(w->dapm);
- u16 gain_reg;
u16 reg;
- int val;
- int offset_val = 0;
if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT0 INTERP"))) {
reg = WCD9335_CDC_RX0_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX0_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT1 INTERP"))) {
reg = WCD9335_CDC_RX1_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX1_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT2 INTERP"))) {
reg = WCD9335_CDC_RX2_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX2_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT3 INTERP"))) {
reg = WCD9335_CDC_RX3_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX3_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT4 INTERP"))) {
reg = WCD9335_CDC_RX4_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX4_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT5 INTERP"))) {
reg = WCD9335_CDC_RX5_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX5_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT6 INTERP"))) {
reg = WCD9335_CDC_RX6_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX6_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT7 INTERP"))) {
reg = WCD9335_CDC_RX7_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX7_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT8 INTERP"))) {
reg = WCD9335_CDC_RX8_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX8_RX_VOL_CTL;
} else {
dev_err(comp->dev, "%s: Interpolator reg not found\n",
__func__);
@@ -3336,9 +3269,6 @@ static int wcd9335_codec_enable_interpolator(struct snd_soc_dapm_widget *w,
break;
case SND_SOC_DAPM_POST_PMU:
wcd9335_config_compander(comp, w->shift, event);
- val = snd_soc_component_read(comp, gain_reg);
- val += offset_val;
- snd_soc_component_write(comp, gain_reg, val);
break;
case SND_SOC_DAPM_POST_PMD:
wcd9335_config_compander(comp, w->shift, event);
@@ -4367,33 +4297,24 @@ static const struct snd_soc_dapm_widget wcd9335_dapm_widgets[] = {
SND_SOC_DAPM_MIXER("SLIM RX5", SND_SOC_NOPM, 0, 0, NULL, 0),
SND_SOC_DAPM_MIXER("SLIM RX6", SND_SOC_NOPM, 0, 0, NULL, 0),
SND_SOC_DAPM_MIXER("SLIM RX7", SND_SOC_NOPM, 0, 0, NULL, 0),
- SND_SOC_DAPM_MUX_E("RX INT0_2 MUX", WCD9335_CDC_RX0_RX_PATH_MIX_CTL,
- 5, 0, &rx_int0_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT1_2 MUX", WCD9335_CDC_RX1_RX_PATH_MIX_CTL,
- 5, 0, &rx_int1_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT2_2 MUX", WCD9335_CDC_RX2_RX_PATH_MIX_CTL,
- 5, 0, &rx_int2_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT3_2 MUX", WCD9335_CDC_RX3_RX_PATH_MIX_CTL,
- 5, 0, &rx_int3_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT4_2 MUX", WCD9335_CDC_RX4_RX_PATH_MIX_CTL,
- 5, 0, &rx_int4_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT5_2 MUX", WCD9335_CDC_RX5_RX_PATH_MIX_CTL,
- 5, 0, &rx_int5_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT6_2 MUX", WCD9335_CDC_RX6_RX_PATH_MIX_CTL,
- 5, 0, &rx_int6_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT7_2 MUX", WCD9335_CDC_RX7_RX_PATH_MIX_CTL,
- 5, 0, &rx_int7_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT8_2 MUX", WCD9335_CDC_RX8_RX_PATH_MIX_CTL,
- 5, 0, &rx_int8_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
+ SND_SOC_DAPM_MUX("RX INT0_2 MUX", WCD9335_CDC_RX0_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int0_2_mux),
+ SND_SOC_DAPM_MUX("RX INT1_2 MUX", WCD9335_CDC_RX1_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int1_2_mux),
+ SND_SOC_DAPM_MUX("RX INT2_2 MUX", WCD9335_CDC_RX2_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int2_2_mux),
+ SND_SOC_DAPM_MUX("RX INT3_2 MUX", WCD9335_CDC_RX3_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int3_2_mux),
+ SND_SOC_DAPM_MUX("RX INT4_2 MUX", WCD9335_CDC_RX4_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int4_2_mux),
+ SND_SOC_DAPM_MUX("RX INT5_2 MUX", WCD9335_CDC_RX5_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int5_2_mux),
+ SND_SOC_DAPM_MUX("RX INT6_2 MUX", WCD9335_CDC_RX6_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int6_2_mux),
+ SND_SOC_DAPM_MUX("RX INT7_2 MUX", WCD9335_CDC_RX7_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int7_2_mux),
+ SND_SOC_DAPM_MUX("RX INT8_2 MUX", WCD9335_CDC_RX8_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int8_2_mux),
SND_SOC_DAPM_MUX("RX INT0_1 MIX1 INP0", SND_SOC_NOPM, 0, 0,
&rx_int0_1_mix_inp0_mux),
SND_SOC_DAPM_MUX("RX INT0_1 MIX1 INP1", SND_SOC_NOPM, 0, 0,
--
2.41.0