2024-01-16 11:02:54

by Colin Ian King

[permalink] [raw]
Subject: [PATCH] rapidio: remove redundant variable tmp

The variable tmp is redundant, it is not being read after the
assignment and hence it can be removed.

Cleans up clang scan build warning:
warning: Although the value stored to 'tmp' is used in the
enclosing expression, the value is never actually read
from 'tmp' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/rapidio/rio-scan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index fdcf742b2adb..8f1bc69f7153 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -528,7 +528,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
{
struct rio_dev *rdev;
u32 regval;
- int tmp;

if (rio_mport_chk_dev_access(port,
RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -562,8 +561,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
hopcount,
RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
- while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
- < port->host_deviceid) {
+ while (rio_get_host_deviceid_lock(port, hopcount) < port->host_deviceid) {
/* Delay a bit */
mdelay(1);
/* Attempt to acquire device lock again */
--
2.39.2