2024-01-16 18:18:28

by Ninad Palsule

[permalink] [raw]
Subject: [PATCH v2 0/1] Add more compatibility strings to tpm-tis-i2c

The new IBM system1 bmc machine uses Nuvoton TPM chip. I had this commit
as part of the device tree for new machine but reviewer suggested send
the driver commit as separate patch. The version 2 includes common
compatibility string for TPM 2.0.

The patchset for IBM system1 bmc machine device tree is as follows:
https://lore.kernel.org/linux-kernel/[email protected]/

Joel Stanley (1):
tpm: tis-i2c: Add more compatible strings

drivers/char/tpm/tpm_tis_i2c.c | 1 +
1 file changed, 1 insertion(+)

--
2.39.2



2024-01-16 18:38:25

by Ninad Palsule

[permalink] [raw]
Subject: [PATCH v2 1/1] tpm: tis-i2c: Add more compatible strings

From: Joel Stanley <[email protected]>

Add a generic compatibility string for I2C based TPM 2.0 device.

Signed-off-by: Joel Stanley <[email protected]>
Signed-off-by: Ninad Palsule <[email protected]>
---
This patch is based out of following patchset:
https://lore.kernel.org/r/[email protected]
This patchset has 3 patches. The binding document related patches are
already merged using following patchset:
https://lore.kernel.org/all/3f56f0a2bb90697a23e83583a21684b75dc7eea2.1701093036.git.lukas@wunner.de/

v2:
- Removed NPCT75x compatibility string based on review comment by
Conor.
---
drivers/char/tpm/tpm_tis_i2c.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
index a897402cc36a..d63ef81fb1f1 100644
--- a/drivers/char/tpm/tpm_tis_i2c.c
+++ b/drivers/char/tpm/tpm_tis_i2c.c
@@ -383,6 +383,7 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
#ifdef CONFIG_OF
static const struct of_device_id of_tis_i2c_match[] = {
{ .compatible = "infineon,slb9673", },
+ { .compatible = "tcg,tpm-tis-i2c", },
{}
};
MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
--
2.39.2


2024-02-02 15:15:28

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] tpm: tis-i2c: Add more compatible strings

On Tue, Jan 16, 2024 at 12:17:54PM -0600, Ninad Palsule wrote:
> From: Joel Stanley <[email protected]>
>
> Add a generic compatibility string for I2C based TPM 2.0 device.
>
> Signed-off-by: Joel Stanley <[email protected]>
> Signed-off-by: Ninad Palsule <[email protected]>

FWIW:

Tested-by: Guenter Roeck <[email protected]>

with qemu and tacoma-bmc.

Thanks,
Guenter