2024-01-17 23:50:06

by Florian Fainelli

Subject: [PATCH] MIPS: Alchemy: Fix missing prototypes

We have a number of missing prototypes warnings for board_setup(),
alchemy_set_lpj() and prom_init_cmdline(), prom_getenv() and
prom_get_ethernet_addr(). Fix those by providing definitions for the
first two functions in au1000.h which is included everywhere relevant,
and including prom.h for the last three.

Signed-off-by: Florian Fainelli <[email protected]>
---
arch/mips/alchemy/common/prom.c | 1 +
arch/mips/alchemy/common/setup.c | 4 +---
arch/mips/include/asm/mach-au1x00/au1000.h | 3 +++
3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/mips/alchemy/common/prom.c b/arch/mips/alchemy/common/prom.c
index b13d8adf3be4..20d30f6265cd 100644
--- a/arch/mips/alchemy/common/prom.c
+++ b/arch/mips/alchemy/common/prom.c
@@ -40,6 +40,7 @@
#include <linux/string.h>

#include <asm/bootinfo.h>
+#include <prom.h>

int prom_argc;
char **prom_argv;
diff --git a/arch/mips/alchemy/common/setup.c b/arch/mips/alchemy/common/setup.c
index 2388d68786f4..a7a6d31a7a41 100644
--- a/arch/mips/alchemy/common/setup.c
+++ b/arch/mips/alchemy/common/setup.c
@@ -30,13 +30,11 @@
#include <linux/mm.h>
#include <linux/dma-map-ops.h> /* for dma_default_coherent */

+#include <asm/bootinfo.h>
#include <asm/mipsregs.h>

#include <au1000.h>

-extern void __init board_setup(void);
-extern void __init alchemy_set_lpj(void);
-
static bool alchemy_dma_coherent(void)
{
switch (alchemy_get_cputype()) {
diff --git a/arch/mips/include/asm/mach-au1x00/au1000.h b/arch/mips/include/asm/mach-au1x00/au1000.h
index a7eec3364a64..41546777902b 100644
--- a/arch/mips/include/asm/mach-au1x00/au1000.h
+++ b/arch/mips/include/asm/mach-au1x00/au1000.h
@@ -597,6 +597,9 @@

#include <asm/cpu.h>

+void alchemy_set_lpj(void);
+void board_setup(void);
+
/* helpers to access the SYS_* registers */
static inline unsigned long alchemy_rdsys(int regofs)
{
--
2.34.1

2024-01-22 10:19:17

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: Alchemy: Fix missing prototypes

On Wed, Jan 17, 2024 at 03:49:44PM -0800, Florian Fainelli wrote:
> We have a number of missing prototypes warnings for board_setup(),
> alchemy_set_lpj() and prom_init_cmdline(), prom_getenv() and
> prom_get_ethernet_addr(). Fix those by providing definitions for the
> first two functions in au1000.h which is included everywhere relevant,
> and including prom.h for the last three.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> arch/mips/alchemy/common/prom.c | 1 +
> arch/mips/alchemy/common/setup.c | 4 +---
> arch/mips/include/asm/mach-au1x00/au1000.h | 3 +++
> 3 files changed, 5 insertions(+), 3 deletions(-)

applied to mips-fixes.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]