2024-01-18 02:02:02

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] scsi: fnic: clean up some inconsistent indenting

No functional modification involved.

drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7930
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/fnic/fnic_scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 8d7fc5284293..5b4768e669f0 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -1961,8 +1961,8 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)

if (!(fnic_priv(sc)->flags & (FNIC_IO_ABORTED | FNIC_IO_DONE))) {
spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
- FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
- "Issuing host reset due to out of order IO\n");
+ FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
+ "Issuing host reset due to out of order IO\n");

ret = FAILED;
goto fnic_abort_cmd_end;
--
2.20.1.7.g153144c



Subject: RE: [PATCH] scsi: fnic: clean up some inconsistent indenting

On Wednesday, January 17, 2024 6:01 PM, Jiapeng Chong <[email protected]> wrote:
>
> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7930
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 8d7fc5284293..5b4768e669f0 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -1961,8 +1961,8 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)
>
> if (!(fnic_priv(sc)->flags & (FNIC_IO_ABORTED | FNIC_IO_DONE))) {
> spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
> - FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
> - "Issuing host reset due to out of order IO\n");
> + FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
> + "Issuing host reset due to out of order IO\n");
>
> ret = FAILED;
> goto fnic_abort_cmd_end;
> --
> 2.20.1.7.g153144c
>

Looks good to me.

Reviewed-by: Karan Tilak Kumar <[email protected]>

Regards,
Karan

2024-01-24 02:54:51

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: fnic: clean up some inconsistent indenting


Jiapeng,

> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.

Applied to 6.9/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2024-01-30 02:32:12

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: fnic: clean up some inconsistent indenting

On Thu, 18 Jan 2024 10:01:28 +0800, Jiapeng Chong wrote:

> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
>
>

Applied to 6.9/scsi-queue, thanks!

[1/1] scsi: fnic: clean up some inconsistent indenting
https://git.kernel.org/mkp/scsi/c/f1aa6437733a

--
Martin K. Petersen Oracle Linux Engineering