2024-01-19 05:56:15

by Randy Dunlap

Subject: [PATCH] dmaengine: imx-sdma: fix Excess kernel-doc warnings

Fix warnings of "Excess struct member" by removing those lines.
They are extraneous.

imx-sdma.c:467: warning: Excess struct member 'context_loaded' description in 'sdma_channel'
imx-sdma.c:467: warning: Excess struct member 'bd_pool' description in 'sdma_channel'
imx-sdma.c:500: warning: Excess struct member 'script_addrs' description in 'sdma_firmware_header'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/dma/imx-sdma.c | 4 ----
1 file changed, 4 deletions(-)

diff -- a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -421,9 +421,7 @@ struct sdma_desc {
* @shp_addr: value for gReg[6]
* @per_addr: value for gReg[2]
* @status: status of dma channel
- * @context_loaded: ensure context is only loaded once
* @data: specific sdma interface structure
- * @bd_pool: dma_pool for bd
* @terminate_worker: used to call back into terminate work function
* @terminated: terminated list
* @is_ram_script: flag for script in ram
@@ -486,8 +484,6 @@ struct sdma_channel {
* @num_script_addrs: Number of script addresses in this image
* @ram_code_start: offset of SDMA ram image in this firmware image
* @ram_code_size: size of SDMA ram image
- * @script_addrs: Stores the start address of the SDMA scripts
- * (in SDMA memory space)
*/
struct sdma_firmware_header {
u32 magic;

2024-01-19 12:50:44

by Vinod Koul

Subject: Re: [PATCH] dmaengine: imx-sdma: fix Excess kernel-doc warnings

On Thu, 18 Jan 2024 19:28:32 -0800, Randy Dunlap wrote:
> Fix warnings of "Excess struct member" by removing those lines.
> They are extraneous.
>
> imx-sdma.c:467: warning: Excess struct member 'context_loaded' description in 'sdma_channel'
> imx-sdma.c:467: warning: Excess struct member 'bd_pool' description in 'sdma_channel'
> imx-sdma.c:500: warning: Excess struct member 'script_addrs' description in 'sdma_firmware_header'
>
> [...]

Applied, thanks!

[1/1] dmaengine: imx-sdma: fix Excess kernel-doc warnings
commit: 98373a21159379341742dadd6c038fe8ff34d9a1

Best regards,
--
~Vinod