2024-01-21 22:42:17

by Marijn Suijten

Subject: [PATCH v2 1/6] arm64: dts: qcom: pmi8950: Add USB vbus and id sensing nodes

USB sensing is performed on the PMIC, exposed as extcon nodes for use in
the relevant USB (otg) driver nodes as the hardware itself is not able
to sense USB presence (5V vbus) nor the role (ID pin).

Signed-off-by: Marijn Suijten <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
---
arch/arm64/boot/dts/qcom/pmi8950.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index 1029f3b1bb9a..49e97ebdbb3c 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -12,6 +12,20 @@ pmic@2 {
#address-cells = <1>;
#size-cells = <0>;

+ pmi8950_usb_id: usb-id@1100 {
+ compatible = "qcom,pm8941-misc";
+ reg = <0x1100>;
+ interrupts = <0x2 0x11 0x3 IRQ_TYPE_NONE>;
+ interrupt-names = "usb_id";
+ };
+
+ pmi8950_usb_vbus: usb-detect@1300 {
+ compatible = "qcom,pm8941-misc";
+ reg = <0x1300>;
+ interrupts = <0x2 0x13 0x2 IRQ_TYPE_NONE>;
+ interrupt-names = "usb_vbus";
+ };
+
pmi8950_vadc: adc@3100 {
compatible = "qcom,spmi-vadc";
reg = <0x3100>;

--
2.43.0

2024-02-06 19:06:50

by Konrad Dybcio

Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: pmi8950: Add USB vbus and id sensing nodes

On 21.01.2024 23:33, Marijn Suijten wrote:
> USB sensing is performed on the PMIC, exposed as extcon nodes for use in
> the relevant USB (otg) driver nodes as the hardware itself is not able
> to sense USB presence (5V vbus) nor the role (ID pin).
>
> Signed-off-by: Marijn Suijten <[email protected]>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
> ---

I hope the USB_ID thing won't mess with a possible future charger impl

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad