2024-01-22 11:49:46

by Rui Salvaterra

Subject: [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values

We have self-explanatory constants for Intel HDA devices, let's use them instead
of magic numbers and code comments.

Signed-off-by: Rui Salvaterra <[email protected]>
---
sound/pci/hda/hda_intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 2276adc84478..66f013ee160d 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1729,8 +1729,8 @@ static int default_bdl_pos_adj(struct azx *chip)
/* some exceptions: Atoms seem problematic with value 1 */
if (chip->pci->vendor == PCI_VENDOR_ID_INTEL) {
switch (chip->pci->device) {
- case 0x0f04: /* Baytrail */
- case 0x2284: /* Braswell */
+ case PCI_DEVICE_ID_INTEL_HDA_BYT:
+ case PCI_DEVICE_ID_INTEL_HDA_BSW:
return 32;
}
}
--
2.43.0

2024-01-22 11:54:34

by Amadeusz Sławiński

Subject: Re: [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values

On 1/22/2024 12:45 PM, Rui Salvaterra wrote:
> We have self-explanatory constants for Intel HDA devices, let's use them instead
> of magic numbers and code comments.
>
> Signed-off-by: Rui Salvaterra <[email protected]>
> ---
> sound/pci/hda/hda_intel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 2276adc84478..66f013ee160d 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1729,8 +1729,8 @@ static int default_bdl_pos_adj(struct azx *chip)
> /* some exceptions: Atoms seem problematic with value 1 */
> if (chip->pci->vendor == PCI_VENDOR_ID_INTEL) {
> switch (chip->pci->device) {
> - case 0x0f04: /* Baytrail */
> - case 0x2284: /* Braswell */
> + case PCI_DEVICE_ID_INTEL_HDA_BYT:
> + case PCI_DEVICE_ID_INTEL_HDA_BSW:
> return 32;
> }
> }

Reviewed-by: Amadeusz Sławiński <[email protected]>

2024-01-23 07:51:13

by Takashi Iwai

Subject: Re: [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values

On Mon, 22 Jan 2024 12:45:12 +0100,
Rui Salvaterra wrote:
>
> We have self-explanatory constants for Intel HDA devices, let's use them instead
> of magic numbers and code comments.
>
> Signed-off-by: Rui Salvaterra <[email protected]>

Applied both patches now. Thanks.


Takashi