2024-01-22 10:23:50

by Lukas Bulwahn

Subject: [PATCH] maple_tree: avoid duplicate variable init in mast_spanning_rebalance()

The local variables r_tmp and l_tmp in mast_spanning_rebalance() are
already initialized at its declaration; there is no need to assign the
value again.

Remove the duplicate initialization of {r,l}_tmp. No functional change.
Due to common compiler optimizations, also no change to object code.

This issue was identified with clang-analyzer's dead stores analysis.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
lib/maple_tree.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 7b161802860b..82fb5195c235 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
struct ma_state l_tmp = *mast->orig_l;
unsigned char depth = 0;

- r_tmp = *mast->orig_r;
- l_tmp = *mast->orig_l;
do {
mas_ascend(mast->orig_r);
mas_ascend(mast->orig_l);
--
2.17.1

2024-01-22 15:24:55

by Liam R. Howlett

Subject: Re: [PATCH] maple_tree: avoid duplicate variable init in mast_spanning_rebalance()

* Lukas Bulwahn <[email protected]> [240122 05:22]:
> The local variables r_tmp and l_tmp in mast_spanning_rebalance() are
> already initialized at its declaration; there is no need to assign the
> value again.
>
> Remove the duplicate initialization of {r,l}_tmp. No functional change.
> Due to common compiler optimizations, also no change to object code.

Hello!

Thanks for this patch and well stated change log.

>
> This issue was identified with clang-analyzer's dead stores analysis.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>

Reviewed-by: Liam R. Howlett <[email protected]>

> ---
> lib/maple_tree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 7b161802860b..82fb5195c235 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
> struct ma_state l_tmp = *mast->orig_l;
> unsigned char depth = 0;
>
> - r_tmp = *mast->orig_r;
> - l_tmp = *mast->orig_l;
> do {
> mas_ascend(mast->orig_r);
> mas_ascend(mast->orig_l);
> --
> 2.17.1
>