2024-01-22 19:06:39

by Breno Leitao

Subject: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the FEC (MPC8xx) Ethernet controller.

Signed-off-by: Breno Leitao <[email protected]>
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index d42594f32275..c56807b757dc 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {

module_platform_driver(fec_driver);

+MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet driver");
MODULE_LICENSE("GPL");
--
2.39.3

2024-01-23 02:14:49

by Wei Fang

Subject: RE: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec

> -----Original Message-----
> From: Breno Leitao <[email protected]>
> Sent: 2024??1??23?? 2:46
> To: [email protected]; [email protected]; [email protected];
> [email protected]; Wei Fang <[email protected]>; Shenwei Wang
> <[email protected]>; Clark Wang <[email protected]>;
> dl-linux-imx <[email protected]>; Paolo Abeni <[email protected]>
> Cc: [email protected]; [email protected]; open list:FREESCALE IMX /
> MXC FEC DRIVER <[email protected]>; open list
> <[email protected]>
> Subject: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec
>
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the FEC (MPC8xx) Ethernet controller.
>
> Signed-off-by: Breno Leitao <[email protected]>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d42594f32275..c56807b757dc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
>
> module_platform_driver(fec_driver);
>
> +MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet
> driver");

Thank you very much for this patch. It would be better if you change the
description to " NXP Fast Ethernet Controller (FEC) driver".

> MODULE_LICENSE("GPL");
> --
> 2.39.3