2024-01-22 19:52:21

by Breno Leitao

Subject: [PATCH net-next 21/22] net: fill in MODULE_DESCRIPTION()s for cpsw-common

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the TI CPSW switch module.

Signed-off-by: Breno Leitao <[email protected]>
---
drivers/net/ethernet/ti/cpsw-common.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 26dc906eae90..57fe936bb177 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -90,4 +90,5 @@ int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
}
EXPORT_SYMBOL_GPL(ti_cm_get_macid);

+MODULE_DESCRIPTION("TI CPSW Switch common module");
MODULE_LICENSE("GPL");
--
2.39.3

2024-01-23 09:54:11

by Roger Quadros

Subject: Re: [PATCH net-next 21/22] net: fill in MODULE_DESCRIPTION()s for cpsw-common

On 22/01/2024 20:45, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the TI CPSW switch module.
>
> Signed-off-by: Breno Leitao <[email protected]>
> ---
> drivers/net/ethernet/ti/cpsw-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
> index 26dc906eae90..57fe936bb177 100644
> --- a/drivers/net/ethernet/ti/cpsw-common.c
> +++ b/drivers/net/ethernet/ti/cpsw-common.c
> @@ -90,4 +90,5 @@ int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
> }
> EXPORT_SYMBOL_GPL(ti_cm_get_macid);
>
> +MODULE_DESCRIPTION("TI CPSW Switch common module");
> MODULE_LICENSE("GPL");

Reviewed-by: Roger Quadros <[email protected]>

--
cheers,
-roger