2024-01-22 19:18:20

by Breno Leitao

Subject: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.

Signed-off-by: Breno Leitao <[email protected]>
---
drivers/net/ethernet/mscc/ocelot.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 56ccbd4c37fe..12999d9be3af 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
}
EXPORT_SYMBOL(ocelot_deinit_port);

+MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");
MODULE_LICENSE("Dual MIT/GPL");
--
2.39.3

2024-01-23 07:40:54

by Horatiu Vultur

Subject: Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

The 01/22/2024 10:45, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
>
> Signed-off-by: Breno Leitao <[email protected]>

Reviewed-by: Horatiu Vultur <[email protected]>

> ---
> drivers/net/ethernet/mscc/ocelot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..12999d9be3af 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> }
> EXPORT_SYMBOL(ocelot_deinit_port);
>
> +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");
> MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.39.3
>

--
/Horatiu

2024-01-23 07:48:51

by Alexandre Belloni

Subject: Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

Hello,

On 22/01/2024 10:45:35-0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
>
> Signed-off-by: Breno Leitao <[email protected]>
> ---
> drivers/net/ethernet/mscc/ocelot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..12999d9be3af 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> }
> EXPORT_SYMBOL(ocelot_deinit_port);
>
> +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");

Shouldn't that mention that this is related to the Ethernet switch?

> MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.39.3
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2024-01-23 15:49:18

by Breno Leitao

Subject: Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

On Tue, Jan 23, 2024 at 08:48:26AM +0100, Alexandre Belloni wrote:
> Hello,
>
> On 22/01/2024 10:45:35-0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> >
> > Signed-off-by: Breno Leitao <[email protected]>
> > ---
> > drivers/net/ethernet/mscc/ocelot.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> > index 56ccbd4c37fe..12999d9be3af 100644
> > --- a/drivers/net/ethernet/mscc/ocelot.c
> > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> > }
> > EXPORT_SYMBOL(ocelot_deinit_port);
> >
> > +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");
>
> Shouldn't that mention that this is related to the Ethernet switch?

sure. let me update it.