2024-01-24 00:44:42

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] ASoC: codecs: Remove unneeded semicolon

In the wcd939x codec driver, there are two instances where semicolons
are used after closing braces of a switch-case statement. These
semicolons are not required and do not adhere to the coding style
guidelines.

This patch removes the unnecessary semicolons at the end of the
switch-case statements which cleans up the code and ensures consistency
with the rest of the kernel coding style.

Signed-off-by: Yang Li <[email protected]>
---
sound/soc/codecs/wcd939x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c
index 0ccc7b31d0c1..c49894aad8a5 100644
--- a/sound/soc/codecs/wcd939x.c
+++ b/sound/soc/codecs/wcd939x.c
@@ -970,7 +970,7 @@ static int wcd939x_codec_enable_dmic(struct snd_soc_dapm_widget *w,
default:
dev_err(component->dev, "%s: Invalid DMIC Selection\n", __func__);
return -EINVAL;
- };
+ }

switch (event) {
case SND_SOC_DAPM_PRE_PMU:
@@ -1292,7 +1292,7 @@ static int wcd939x_micbias_control(struct snd_soc_component *component,
dev_err(component->dev, "%s: Invalid micbias number: %d\n",
__func__, micb_num);
return -EINVAL;
- };
+ }

switch (req) {
case MICB_PULLUP_ENABLE:
--
2.20.1.7.g153144c



2024-01-25 13:39:25

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] ASoC: codecs: Remove unneeded semicolon

On Wed, 24 Jan 2024 08:44:25 +0800, Yang Li wrote:
> In the wcd939x codec driver, there are two instances where semicolons
> are used after closing braces of a switch-case statement. These
> semicolons are not required and do not adhere to the coding style
> guidelines.
>
> This patch removes the unnecessary semicolons at the end of the
> switch-case statements which cleans up the code and ensures consistency
> with the rest of the kernel coding style.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: Remove unneeded semicolon
commit: e7214441ca1562fbfb002200f46d7f83bbc2e621

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark