2024-01-24 10:19:41

by Kunwu Chan

Subject: [PATCH] dmaengine: bestcomm: Code cleanup for bcom_sram_init

This part was commented from commit 2f9ea1bde0d1 ("[POWERPC]
bestcomm: core bestcomm support for Freescale MPC5200") in
about 16 years before.

If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <[email protected]>
---
drivers/dma/bestcomm/sram.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/dma/bestcomm/sram.c b/drivers/dma/bestcomm/sram.c
index 0553956f7456..ad74d57cc3ab 100644
--- a/drivers/dma/bestcomm/sram.c
+++ b/drivers/dma/bestcomm/sram.c
@@ -90,13 +90,8 @@ int bcom_sram_init(struct device_node *sram_node, char *owner)
bcom_sram->rh = rh_create(4);

/* Attach the free zones */
-#if 0
- /* Currently disabled ... for future use only */
- reg_addr_p = of_get_property(sram_node, "available", &psize);
-#else
regaddr_p = NULL;
psize = 0;
-#endif

if (!regaddr_p || !psize) {
/* Attach the whole zone */
--
2.39.2

2024-01-30 16:51:27

by Vinod Koul

Subject: Re: [PATCH] dmaengine: bestcomm: Code cleanup for bcom_sram_init

On Wed, 24 Jan 2024 17:55:02 +0800, Kunwu Chan wrote:
> This part was commented from commit 2f9ea1bde0d1 ("[POWERPC]
> bestcomm: core bestcomm support for Freescale MPC5200") in
> about 16 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> [...]

Applied, thanks!

[1/1] dmaengine: bestcomm: Code cleanup for bcom_sram_init
commit: 7510bf84c4e318bff63b13183929a4272e1d2b5d

Best regards,
--
~Vinod