2024-01-24 15:46:10

by Hugo Villeneuve

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: arm: fsl: remove redundant company name

From: Hugo Villeneuve <[email protected]>

Company name in compatible description appears twice, which is not really
helpful, so remove it from product name.

Signed-off-by: Hugo Villeneuve <[email protected]>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 228dcc5c7d6f..f455c0172c84 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1026,7 +1026,7 @@ properties:
items:
- enum:
- dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
- - rve,rve-gateway # i.MX8MN RVE Gateway Board
+ - rve,gateway # i.MX8MN RVE Gateway Board
- variscite,var-som-mx8mn-symphony
- const: variscite,var-som-mx8mn
- const: fsl,imx8mn
--
2.39.2



2024-01-24 16:01:05

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: remove redundant company name

On Wed, Jan 24, 2024 at 10:44:20AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <[email protected]>
>
> Company name in compatible description appears twice, which is not really
> helpful, so remove it from product name.
>
> Signed-off-by: Hugo Villeneuve <[email protected]>

This only landed in 6.8-rc1, right?
With a Fixes: tag this would probably be okay, but this does seem on the
"not worth fixing" side of things to be honest.

Cheers,
Conor.

> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 228dcc5c7d6f..f455c0172c84 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1026,7 +1026,7 @@ properties:
> items:
> - enum:
> - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
> - - rve,rve-gateway # i.MX8MN RVE Gateway Board
> + - rve,gateway # i.MX8MN RVE Gateway Board
> - variscite,var-som-mx8mn-symphony
> - const: variscite,var-som-mx8mn
> - const: fsl,imx8mn
> --
> 2.39.2
>

Attachments:
(No filename) (1.28 kB)
 signature.asc (235.00 B)
 Download all attachments

2024-01-24 16:59:30

by Hugo Villeneuve

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: remove redundant company name

On Wed, 24 Jan 2024 16:00:48 +0000
Conor Dooley <[email protected]> wrote:

> On Wed, Jan 24, 2024 at 10:44:20AM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <[email protected]>
> >
> > Company name in compatible description appears twice, which is not really
> > helpful, so remove it from product name.
> >
> > Signed-off-by: Hugo Villeneuve <[email protected]>
>
> This only landed in 6.8-rc1, right?

Hi,
yes.

> With a Fixes: tag this would probably be okay, but this does seem on the
> "not worth fixing" side of things to be honest.

I will add a "Fixes:" tag then, because for me it is worth fixing.

Hugo Villeneuve


>
> Cheers,
> Conor.
>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 228dcc5c7d6f..f455c0172c84 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1026,7 +1026,7 @@ properties:
> > items:
> > - enum:
> > - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
> > - - rve,rve-gateway # i.MX8MN RVE Gateway Board
> > + - rve,gateway # i.MX8MN RVE Gateway Board
> > - variscite,var-som-mx8mn-symphony
> > - const: variscite,var-som-mx8mn
> > - const: fsl,imx8mn
> > --
> > 2.39.2
> >