2024-01-24 17:07:10

by Frederic Weisbecker

Subject: [PATCH 05/15] tick: s/tick_nohz_stop_sched_tick/tick_nohz_full_stop_tick

tick_nohz_stop_sched_tick() is only about nohz_full and not about
dynticks-idle. Reflect that in the function name to avoid confusion.

Signed-off-by: Frederic Weisbecker <[email protected]>
---
kernel/time/tick-sched.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index c311b7388685..4089bd274d8e 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -998,7 +998,7 @@ static void tick_nohz_retain_tick(struct tick_sched *ts)
}

#ifdef CONFIG_NO_HZ_FULL
-static void tick_nohz_stop_sched_tick(struct tick_sched *ts, int cpu)
+static void tick_nohz_full_stop_tick(struct tick_sched *ts, int cpu)
{
if (tick_nohz_next_event(ts, cpu))
tick_nohz_stop_tick(ts, cpu);
@@ -1033,7 +1033,7 @@ static void __tick_nohz_full_update_tick(struct tick_sched *ts,
int cpu = smp_processor_id();

if (can_stop_full_tick(cpu, ts))
- tick_nohz_stop_sched_tick(ts, cpu);
+ tick_nohz_full_stop_tick(ts, cpu);
else if (ts->tick_stopped)
tick_nohz_restart_sched_tick(ts, now);
#endif
--
2.43.0

2024-01-25 09:41:21

by Thomas Gleixner

Subject: Re: [PATCH 05/15] tick: s/tick_nohz_stop_sched_tick/tick_nohz_full_stop_tick

On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:
> tick_nohz_stop_sched_tick() is only about nohz_full and not about
> dynticks-idle. Reflect that in the function name to avoid confusion.
>
> Signed-off-by: Frederic Weisbecker <[email protected]>

Reviewed-by: Thomas Gleixner <[email protected]>