2024-01-24 16:18:20

by Bartosz Golaszewski

Subject: [PATCH] gpio: cdev: remove leftover function pointer typedefs

From: Bartosz Golaszewski <[email protected]>

The locking wrappers were replaces with lock guards. These typedefs are
no longer needed.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/gpio/gpiolib-cdev.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 2a88736629ef..34d6712fa07c 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
* interface to gpiolib GPIOs via ioctl()s.
*/

-typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
-typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
-typedef ssize_t (*read_fn)(struct file *, char __user *,
- size_t count, loff_t *);
-
/*
* GPIO line handle management
*/
--
2.40.1

2024-01-24 23:43:37

by Kent Gibson

Subject: Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs

On Wed, Jan 24, 2024 at 05:17:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> The locking wrappers were replaces with lock guards. These typedefs are
> no longer needed.
>

replaced

Given that,

Reviewed-by: Kent Gibson <[email protected]>

> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/gpio/gpiolib-cdev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 2a88736629ef..34d6712fa07c 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
> * interface to gpiolib GPIOs via ioctl()s.
> */
>
> -typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
> -typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
> -typedef ssize_t (*read_fn)(struct file *, char __user *,
> - size_t count, loff_t *);
> -
> /*
> * GPIO line handle management
> */
> --
> 2.40.1
>

2024-01-31 08:13:11

by Linus Walleij

Subject: Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs

On Wed, Jan 24, 2024 at 5:17 PM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> The locking wrappers were replaces with lock guards. These typedefs are
> no longer needed.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij