Fix an obvious spelling error in the PMIC compatible in the MMP2
Brownstone DTS file.
Without this, the PMIC would never probe.
Fixes: 58f1193e6210 ("mfd: max8925: Add dts")
Cc: <[email protected]>
Signed-off-by: Duje Mihanović <[email protected]>
---
Changes in v2:
- Address maintainer comments:
- Add Fixes: and Cc: tags
- Change "for" to "in" in subject
- Emphasize PMIC's inability to probe without patch
- Link to v1: https://lore.kernel.org/r/[email protected]
---
arch/arm/boot/dts/marvell/mmp2-brownstone.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/marvell/mmp2-brownstone.dts b/arch/arm/boot/dts/marvell/mmp2-brownstone.dts
index 04f1ae1382e7..bc64348b8218 100644
--- a/arch/arm/boot/dts/marvell/mmp2-brownstone.dts
+++ b/arch/arm/boot/dts/marvell/mmp2-brownstone.dts
@@ -28,7 +28,7 @@ &uart3 {
&twsi1 {
status = "okay";
pmic: max8925@3c {
- compatible = "maxium,max8925";
+ compatible = "maxim,max8925";
reg = <0x3c>;
interrupts = <1>;
interrupt-parent = <&intcmux4>;
---
base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421
change-id: 20230804-brownstone-typo-fix-f5b16c47d865
Best regards,
--
Duje Mihanović <[email protected]>
On 25/01/2024 19:39, Duje Mihanović wrote:
> Fix an obvious spelling error in the PMIC compatible in the MMP2
> Brownstone DTS file.
>
> Without this, the PMIC would never probe.
>
> Fixes: 58f1193e6210 ("mfd: max8925: Add dts")
> Cc: <[email protected]>
> Signed-off-by: Duje Mihanović <[email protected]>
> ---
Patch from 2014:
https://lore.kernel.org/linux-devicetree/[email protected]/
Then 2021:
https://lore.kernel.org/linux-devicetree/[email protected]/
Mine from 2014 probably does not apply anymore... But at least please
give me credits for finding this 10 years ago:
Reported-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 25/01/2024 19:39, Duje Mihanović wrote:
> Fix an obvious spelling error in the PMIC compatible in the MMP2
> Brownstone DTS file.
>
> Without this, the PMIC would never probe.
It would - vendor prefix can be ignored.
Also, you got here tag...
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
On Thu, 25 Jan 2024 19:39:32 +0100, Duje Mihanović wrote:
> Fix an obvious spelling error in the PMIC compatible in the MMP2
> Brownstone DTS file.
>
> Without this, the PMIC would never probe.
>
>
Corrected commit msg, took Andrew tag (thanks!).
Applied, thanks!
[1/1] arm: marvell: Fix maxium->maxim typo in brownstone dts
https://git.kernel.org/krzk/linux-dt/c/b589f7aaf96330236a6d6a4057880550b066b581
Best regards,
--
Krzysztof Kozlowski <[email protected]>