2024-01-25 21:36:02

by Luca Weiss

[permalink] [raw]
Subject: [PATCH v2 0/3] Add MDSS_BCR reset (+some more) for MSM8953

Add the MDSS_BCR reset that is found in the GCC of MSM8953 so we can
make sure the MDSS gets properly reset before Linux starts using it.

Also add some others that have been found in the LK sources.

Signed-off-by: Luca Weiss <[email protected]>
---
Changes in v2:
- Add more resets from LK sources
- Pick up tags
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Vladimir Lypak (3):
dt-bindings: clock: gcc-msm8953: add more resets
clk: qcom: gcc-msm8953: add more resets
arm64: dts: qcom: msm8953: add reset for display subsystem

arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 ++
drivers/clk/qcom/gcc-msm8953.c | 4 ++++
include/dt-bindings/clock/qcom,gcc-msm8953.h | 4 ++++
3 files changed, 10 insertions(+)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240123-msm8953-mdss-reset-68308a03fff5

Best regards,
--
Luca Weiss <[email protected]>



2024-01-26 21:35:11

by Luca Weiss

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem

From: Vladimir Lypak <[email protected]>

With this reset we can avoid situations like IRQ storms from DSI host
before it even started probing (because boot-loader left DSI IRQs on).

Signed-off-by: Vladimir Lypak <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index ad2f8cf9c966..dcb5c98b793c 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -859,6 +859,8 @@ mdss: display-subsystem@1a00000 {
"vsync",
"core";

+ resets = <&gcc GCC_MDSS_BCR>;
+
#address-cells = <1>;
#size-cells = <1>;
ranges;

--
2.43.0


2024-01-26 21:41:21

by Luca Weiss

[permalink] [raw]
Subject: [PATCH v2 2/3] clk: qcom: gcc-msm8953: add more resets

From: Vladimir Lypak <[email protected]>

Add new entries in the gcc driver for some more resets found on MSM8953.

Signed-off-by: Vladimir Lypak <[email protected]>
[luca: expand commit message, move entry, add more entries]
Signed-off-by: Luca Weiss <[email protected]>
---
drivers/clk/qcom/gcc-msm8953.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/clk/qcom/gcc-msm8953.c b/drivers/clk/qcom/gcc-msm8953.c
index 3e5a8cb14d4d..68359534ff25 100644
--- a/drivers/clk/qcom/gcc-msm8953.c
+++ b/drivers/clk/qcom/gcc-msm8953.c
@@ -4171,6 +4171,10 @@ static const struct qcom_reset_map gcc_msm8953_resets[] = {
[GCC_USB3PHY_PHY_BCR] = { 0x3f03c },
[GCC_USB3_PHY_BCR] = { 0x3f034 },
[GCC_USB_30_BCR] = { 0x3f070 },
+ [GCC_MDSS_BCR] = { 0x4d074 },
+ [GCC_CRYPTO_BCR] = { 0x16000 },
+ [GCC_SDCC1_BCR] = { 0x42000 },
+ [GCC_SDCC2_BCR] = { 0x43000 },
};

static const struct regmap_config gcc_msm8953_regmap_config = {

--
2.43.0


2024-01-26 21:45:09

by Luca Weiss

[permalink] [raw]
Subject: [PATCH v2 1/3] dt-bindings: clock: gcc-msm8953: add more resets

From: Vladimir Lypak <[email protected]>

Add new defines for some more BCRs found on MSM8953.

Signed-off-by: Vladimir Lypak <[email protected]>
[luca: expand commit message, add more resets]
Acked-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Luca Weiss <[email protected]>
---
include/dt-bindings/clock/qcom,gcc-msm8953.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/include/dt-bindings/clock/qcom,gcc-msm8953.h b/include/dt-bindings/clock/qcom,gcc-msm8953.h
index 783162da6148..13b4a62877e5 100644
--- a/include/dt-bindings/clock/qcom,gcc-msm8953.h
+++ b/include/dt-bindings/clock/qcom,gcc-msm8953.h
@@ -218,6 +218,10 @@
#define GCC_USB3PHY_PHY_BCR 3
#define GCC_USB3_PHY_BCR 4
#define GCC_USB_30_BCR 5
+#define GCC_MDSS_BCR 6
+#define GCC_CRYPTO_BCR 7
+#define GCC_SDCC1_BCR 8
+#define GCC_SDCC2_BCR 9

/* GDSCs */
#define CPP_GDSC 0

--
2.43.0


2024-02-07 04:50:40

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 0/3] Add MDSS_BCR reset (+some more) for MSM8953


On Thu, 25 Jan 2024 22:35:11 +0100, Luca Weiss wrote:
> Add the MDSS_BCR reset that is found in the GCC of MSM8953 so we can
> make sure the MDSS gets properly reset before Linux starts using it.
>
> Also add some others that have been found in the LK sources.
>
>

Applied, thanks!

[3/3] arm64: dts: qcom: msm8953: add reset for display subsystem
commit: 9b4dec638c9cd1e881125894e263b0f824b8f75e

Best regards,
--
Bjorn Andersson <[email protected]>