2024-01-26 03:00:02

by Hui Liu via B4 Relay

Subject: [PATCH RESEND v6] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs

From: Hui Liu <[email protected]>

Add definition for three LEDs to make sure they can
be enabled base on QCOM LPG LED driver.

Signed-off-by: Hui Liu <[email protected]>
---
Changes in v6:
- Updated the seperate LEDs nodes to multi-led setting.
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Rephrased commit text, replaced qcs6490-idp to qcm6490-idp.
- Removed the unnecessary full.
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Removed "label" definition and added "function" definition.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Rephrased commit text and updated the nodes to qcm6490-idp board file.
- Link to v2: https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Rephrased commit text and updated the nodes to board file.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 37c91fdf3ab9..c9e7ddcbd259 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -5,6 +5,7 @@

/dts-v1/;

+#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sc7280.dtsi"
#include "pm7325.dtsi"
@@ -414,6 +415,33 @@ vreg_bob_3p296: bob {
};
};

+&pm8350c_pwm {
+ status = "okay";
+
+ multi-led {
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_STATUS;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};

---
base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
change-id: 20231215-lpg-4aadd374811a

Best regards,
--
Hui Liu <[email protected]>

2024-01-29 03:58:07

by Dmitry Baryshkov

Subject: Re: [PATCH RESEND v6] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs

On Fri, 26 Jan 2024 at 04:57, Hui Liu via B4 Relay
<[email protected]> wrote:
>
> From: Hui Liu <[email protected]>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <[email protected]>
> ---
> Changes in v6:
> - Updated the seperate LEDs nodes to multi-led setting.
> - Link to v5: https://lore.kernel.org/r/[email protected]
>
> Changes in v5:
> - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp.
> - Removed the unnecessary full.
> - Link to v4: https://lore.kernel.org/r/[email protected]
>
> Changes in v4:
> - Removed "label" definition and added "function" definition.
> - Link to v3: https://lore.kernel.org/r/[email protected]
>
> Changes in v3:
> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
> - Link to v2: https://lore.kernel.org/all/[email protected]/
>
> Changes in v2:
> - Rephrased commit text and updated the nodes to board file.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-02-03 17:10:59

by Bjorn Andersson

Subject: Re: [PATCH RESEND v6] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs

On Fri, 26 Jan 2024 10:56:52 +0800, Hui Liu wrote:
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs
commit: 8385383cc2c2f7039ecc57864043112cdc7026c7

Best regards,
--
Bjorn Andersson <[email protected]>