2024-01-26 09:06:48

by Jiapeng Chong

Subject: [PATCH] HID: nintendo: Remove some unused functions

These functions are defined in the hid-nintendo.c file, but not called
elsewhere, so delete these unused functions.

drivers/hid/hid-nintendo.c:757:20: warning: unused function 'joycon_type_has_left_controls'.
drivers/hid/hid-nintendo.c:763:20: warning: unused function 'joycon_type_has_right_controls'.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8060
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/hid/hid-nintendo.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 7ce6be0a8dee..ab5953fc2436 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -754,18 +754,6 @@ static inline bool joycon_type_is_right_nescon(struct joycon_ctlr *ctlr)
return ctlr->ctlr_type == JOYCON_CTLR_TYPE_NESR;
}

-static inline bool joycon_type_has_left_controls(struct joycon_ctlr *ctlr)
-{
- return joycon_type_is_left_joycon(ctlr) ||
- joycon_type_is_procon(ctlr);
-}
-
-static inline bool joycon_type_has_right_controls(struct joycon_ctlr *ctlr)
-{
- return joycon_type_is_right_joycon(ctlr) ||
- joycon_type_is_procon(ctlr);
-}
-
static inline bool joycon_type_is_any_joycon(struct joycon_ctlr *ctlr)
{
return joycon_type_is_left_joycon(ctlr) ||
--
2.20.1.7.g153144c

2024-02-13 15:26:02

by Jiri Kosina

Subject: Re: [PATCH] HID: nintendo: Remove some unused functions

On Fri, 26 Jan 2024, Jiapeng Chong wrote:

> These functions are defined in the hid-nintendo.c file, but not called
> elsewhere, so delete these unused functions.
>
> drivers/hid/hid-nintendo.c:757:20: warning: unused function 'joycon_type_has_left_controls'.
> drivers/hid/hid-nintendo.c:763:20: warning: unused function 'joycon_type_has_right_controls'.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8060
> Signed-off-by: Jiapeng Chong <[email protected]>

No idea why those were added, CCing Ryan, who added those in 94f18bb1994.
I've added a Fixes: tag and applied, thanks.

> ---
> drivers/hid/hid-nintendo.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index 7ce6be0a8dee..ab5953fc2436 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -754,18 +754,6 @@ static inline bool joycon_type_is_right_nescon(struct joycon_ctlr *ctlr)
> return ctlr->ctlr_type == JOYCON_CTLR_TYPE_NESR;
> }
>
> -static inline bool joycon_type_has_left_controls(struct joycon_ctlr *ctlr)
> -{
> - return joycon_type_is_left_joycon(ctlr) ||
> - joycon_type_is_procon(ctlr);
> -}
> -
> -static inline bool joycon_type_has_right_controls(struct joycon_ctlr *ctlr)
> -{
> - return joycon_type_is_right_joycon(ctlr) ||
> - joycon_type_is_procon(ctlr);
> -}
> -
> static inline bool joycon_type_is_any_joycon(struct joycon_ctlr *ctlr)
> {
> return joycon_type_is_left_joycon(ctlr) ||
> --
> 2.20.1.7.g153144c
>

--
Jiri Kosina
SUSE Labs