2024-01-26 11:55:56

by André Draszik

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: samsung: exynos-sysreg: gs101-peric0 requires a clock

.. otherwise it won't be accessible.

Update the schema to make this obvious.

Signed-off-by: André Draszik <[email protected]>

---
v3: no changes, resend as a complete series
v2: no changes
---
.../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 1794e3799f21..33d837ae4f45 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -72,6 +72,7 @@ allOf:
compatible:
contains:
enum:
+ - google,gs101-peric0-sysreg
- samsung,exynos850-cmgp-sysreg
- samsung,exynos850-peri-sysreg
- samsung,exynos850-sysreg
--
2.43.0.429.g432eaa2c6b-goog



2024-01-26 12:03:34

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: samsung: exynos-sysreg: gs101-peric0 requires a clock


On Fri, 26 Jan 2024 11:55:16 +0000, André Draszik wrote:
> ... otherwise it won't be accessible.
>
> Update the schema to make this obvious.
>
>

Applied, thanks!

[1/2] dt-bindings: samsung: exynos-sysreg: gs101-peric0 requires a clock
https://git.kernel.org/krzk/linux/c/38c9ce091a4bd0ff272438131424e98ea0e3906d
[2/2] arm64: dts: exynos: gs101: sysreg_peric0 needs a clock
https://git.kernel.org/krzk/linux/c/ca487bc2776e6b2465fcddb0a0fc121c0ff7b118

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2024-01-26 12:06:31

by André Draszik

[permalink] [raw]
Subject: [PATCH v3 2/2] arm64: dts: exynos: gs101: sysreg_peric0 needs a clock

Without the clock running, we can not access its registers, and now
that we have it, we should add it here so that it gets enabled as
and when needed.

Update the DTSI accordingly.

Signed-off-by: André Draszik <[email protected]>

---
v3: no changes, resend as a complete series
v2: fix subject line
---
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 412d2866dca7..aaac04df5e65 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -364,6 +364,7 @@ cmu_peric0: clock-controller@10800000 {
sysreg_peric0: syscon@10820000 {
compatible = "google,gs101-peric0-sysreg", "syscon";
reg = <0x10820000 0x10000>;
+ clocks = <&cmu_peric0 CLK_GOUT_PERIC0_SYSREG_PERIC0_PCLK>;
};

pinctrl_peric0: pinctrl@10840000 {
--
2.43.0.429.g432eaa2c6b-goog