2024-01-28 10:19:07

by Lucas Tanure

Subject: [PATCH] ptp: lan743x: Use spin_lock instead of spin_lock_bh

lan743x_ptp_request_tx_timestamp uses spin_lock_bh, but it is
only called from lan743x_tx_xmit_frame where all IRQs are
already disabled.

This fixes the "IRQs not enabled as expected" warning.

Signed-off-by: Lucas Tanure <[email protected]>
---
drivers/net/ethernet/microchip/lan743x_ptp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
index 2f04bc77a118..2801f08bf1c9 100644
--- a/drivers/net/ethernet/microchip/lan743x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
@@ -1712,13 +1712,13 @@ bool lan743x_ptp_request_tx_timestamp(struct lan743x_adapter *adapter)
struct lan743x_ptp *ptp = &adapter->ptp;
bool result = false;

- spin_lock_bh(&ptp->tx_ts_lock);
+ spin_lock(&ptp->tx_ts_lock);
if (ptp->pending_tx_timestamps < LAN743X_PTP_NUMBER_OF_TX_TIMESTAMPS) {
/* request granted */
ptp->pending_tx_timestamps++;
result = true;
}
- spin_unlock_bh(&ptp->tx_ts_lock);
+ spin_unlock(&ptp->tx_ts_lock);
return result;
}

--
2.43.0

2024-01-31 23:33:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] ptp: lan743x: Use spin_lock instead of spin_lock_bh

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Sun, 28 Jan 2024 10:18:49 +0000 you wrote:
> lan743x_ptp_request_tx_timestamp uses spin_lock_bh, but it is
> only called from lan743x_tx_xmit_frame where all IRQs are
> already disabled.
>
> This fixes the "IRQs not enabled as expected" warning.
>
> Signed-off-by: Lucas Tanure <[email protected]>
>
> [...]

Here is the summary with links:
- ptp: lan743x: Use spin_lock instead of spin_lock_bh
https://git.kernel.org/netdev/net-next/c/96b93f08357c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html