2024-01-29 14:22:05

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref

dtschema package defines firmware-name as string-array, so individual
bindings should not make it a string but instead just narrow the number
of expected firmware file names.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index c30218684cfe..53cae71d9957 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -159,7 +159,7 @@ properties:
when the AP (not the modem) performs early initialization.

firmware-name:
- $ref: /schemas/types.yaml#/definitions/string
+ maxItems: 1
description:
If present, name (or relative path) of the file within the
firmware search path containing the firmware image used when
--
2.34.1



2024-01-29 16:52:13

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref

On Mon, Jan 29, 2024 at 03:21:21PM +0100, Krzysztof Kozlowski wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

Attachments:
(No filename) (403.00 B)
 signature.asc (235.00 B)
 Download all attachments

2024-01-30 12:18:26

by Alex Elder

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref

On 1/29/24 8:21 AM, Krzysztof Kozlowski wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Fine with me.

Acked-by: Alex Elder <[email protected]>

> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index c30218684cfe..53cae71d9957 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -159,7 +159,7 @@ properties:
> when the AP (not the modem) performs early initialization.
>
> firmware-name:
> - $ref: /schemas/types.yaml#/definitions/string
> + maxItems: 1
> description:
> If present, name (or relative path) of the file within the
> firmware search path containing the firmware image used when


2024-02-01 09:51:15

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:

On Mon, 29 Jan 2024 15:21:21 +0100 you wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- dt-bindings: net: qcom,ipa: do not override firmware-name $ref
https://git.kernel.org/netdev/net-next/c/b2005bb756e1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html