2024-01-30 15:39:15

by Naresh Solanki

Subject: [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK

From: Patrick Rudolph <[email protected]>

Use _pmbus_write_word_data to allow intercepting writes to
PMBUS_SMBALERT_MASK in the custom chip specific code.

This is required for MP2971/MP2973 which doesn't follow the
PMBUS specification for PMBUS_SMBALERT_MASK.

Signed-off-by: Patrick Rudolph <[email protected]>
Signed-off-by: Naresh Solanki <[email protected]>
---
drivers/hwmon/pmbus/pmbus_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 1363d9f89181..cb4c65a7f288 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -3188,7 +3188,7 @@ static int pmbus_regulator_notify(struct pmbus_data *data, int page, int event)

static int pmbus_write_smbalert_mask(struct i2c_client *client, u8 page, u8 reg, u8 val)
{
- return pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
+ return _pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
}

static irqreturn_t pmbus_fault_handler(int irq, void *pdata)

base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a
--
2.42.0

2024-01-30 16:52:08

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK

On Tue, Jan 30, 2024 at 08:59:03PM +0530, Naresh Solanki wrote:
> From: Patrick Rudolph <[email protected]>
>
> Use _pmbus_write_word_data to allow intercepting writes to
> PMBUS_SMBALERT_MASK in the custom chip specific code.
>
> This is required for MP2971/MP2973 which doesn't follow the
> PMBUS specification for PMBUS_SMBALERT_MASK.

Applied, but is there going to be a follow-up patch for those chips ?

Thanks,
Guenter

2024-01-30 17:05:05

by Naresh Solanki

Subject: Re: [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK

Hi Guenter,

On Tue, 30 Jan 2024 at 22:01, Guenter Roeck <[email protected]> wrote:
>
> On Tue, Jan 30, 2024 at 08:59:03PM +0530, Naresh Solanki wrote:
> > From: Patrick Rudolph <[email protected]>
> >
> > Use _pmbus_write_word_data to allow intercepting writes to
> > PMBUS_SMBALERT_MASK in the custom chip specific code.
> >
> > This is required for MP2971/MP2973 which doesn't follow the
> > PMBUS specification for PMBUS_SMBALERT_MASK.
>
> Applied, but is there going to be a follow-up patch for those chips ?
Yes.

Regards,
Naresh
>
> Thanks,
> Guenter