2024-02-02 00:10:49

by Jessica Zhang

[permalink] [raw]
Subject: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

The DSI host must be enabled for the panel to be initialized in
prepare(). Set the prepare_prev_first flag to guarantee this.

Signed-off-by: Jessica Zhang <[email protected]>
---
To: Neil Armstrong <[email protected]>
To: Sam Ravnborg <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Jessica Zhang <[email protected]>
To: Maarten Lankhorst <[email protected]>
To: Maxime Ripard <[email protected]>
To: Thomas Zimmermann <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

Changes in v2:
- Corrected commit message to mention that DCS on commands are sent during
prepare() instead of probe()
- Dropped Fixes tag
- Rebased onto tip of linux-next
- Link to v1: https://lore.kernel.org/r/[email protected]
---
drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
index a23407b9f6fb6..540099253e1bd 100644
--- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
+++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
@@ -287,6 +287,7 @@ static int visionox_vtdr6130_probe(struct mipi_dsi_device *dsi)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_NO_EOT_PACKET |
MIPI_DSI_CLOCK_NON_CONTINUOUS;
+ ctx->panel.prepare_prev_first = true;

drm_panel_init(&ctx->panel, dev, &visionox_vtdr6130_panel_funcs,
DRM_MODE_CONNECTOR_DSI);

---
base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62
change-id: 20230717-visionox-vtdr-prev-first-e00ae02eec9f

Best regards,
--
Jessica Zhang <[email protected]>



2024-02-02 21:33:27

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

On 02/02/2024 01:10, Jessica Zhang wrote:
> The DSI host must be enabled for the panel to be initialized in
> prepare(). Set the prepare_prev_first flag to guarantee this.
>
> Signed-off-by: Jessica Zhang <[email protected]>
> ---
> To: Neil Armstrong <[email protected]>
> To: Sam Ravnborg <[email protected]>
> To: David Airlie <[email protected]>
> To: Daniel Vetter <[email protected]>
> To: Jessica Zhang <[email protected]>
> To: Maarten Lankhorst <[email protected]>
> To: Maxime Ripard <[email protected]>
> To: Thomas Zimmermann <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
>
> Changes in v2:
> - Corrected commit message to mention that DCS on commands are sent during
> prepare() instead of probe()
> - Dropped Fixes tag
> - Rebased onto tip of linux-next
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
> index a23407b9f6fb6..540099253e1bd 100644
> --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
> +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
> @@ -287,6 +287,7 @@ static int visionox_vtdr6130_probe(struct mipi_dsi_device *dsi)
> dsi->format = MIPI_DSI_FMT_RGB888;
> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_NO_EOT_PACKET |
> MIPI_DSI_CLOCK_NON_CONTINUOUS;
> + ctx->panel.prepare_prev_first = true;
>
> drm_panel_init(&ctx->panel, dev, &visionox_vtdr6130_panel_funcs,
> DRM_MODE_CONNECTOR_DSI);
>
> ---
> base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62
> change-id: 20230717-visionox-vtdr-prev-first-e00ae02eec9f
>
> Best regards,

Thx for resending, it's time to merge those.

Acked-by: Neil Armstrong <[email protected]>

2024-02-02 21:36:41

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

Hi,

On Thu, 01 Feb 2024 16:10:15 -0800, Jessica Zhang wrote:
> The DSI host must be enabled for the panel to be initialized in
> prepare(). Set the prepare_prev_first flag to guarantee this.
>
>

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0581bcc48048924f021fa8fae54353402c5d3740

--
Neil