2024-02-02 06:50:07

by Bo Liu

Subject: [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache

The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: Bo Liu <[email protected]>
---
drivers/net/ieee802154/mrf24j40.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ee4cfbf2c5cc..d3f42efc5d1a 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -388,7 +388,7 @@ static const struct regmap_config mrf24j40_short_regmap = {
.pad_bits = 1,
.write_flag_mask = MRF24J40_SHORT_WRITE,
.read_flag_mask = MRF24J40_SHORT_READ,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.max_register = MRF24J40_SHORT_NUMREGS,
.writeable_reg = mrf24j40_short_reg_writeable,
.readable_reg = mrf24j40_short_reg_readable,
@@ -495,7 +495,7 @@ static const struct regmap_config mrf24j40_long_regmap = {
.pad_bits = 5,
.write_flag_mask = MRF24J40_LONG_ACCESS,
.read_flag_mask = MRF24J40_LONG_ACCESS,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.max_register = MRF24J40_LONG_NUMREGS,
.writeable_reg = mrf24j40_long_reg_writeable,
.readable_reg = mrf24j40_long_reg_readable,
--
2.31.1

2024-02-26 20:51:21

by Stefan Schmidt

Subject: Re: [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache

Hello,

On 02.02.24 07:46, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Bo Liu <[email protected]>
> ---
> drivers/net/ieee802154/mrf24j40.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee4cfbf2c5cc..d3f42efc5d1a 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -388,7 +388,7 @@ static const struct regmap_config mrf24j40_short_regmap = {
> .pad_bits = 1,
> .write_flag_mask = MRF24J40_SHORT_WRITE,
> .read_flag_mask = MRF24J40_SHORT_READ,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .max_register = MRF24J40_SHORT_NUMREGS,
> .writeable_reg = mrf24j40_short_reg_writeable,
> .readable_reg = mrf24j40_short_reg_readable,
> @@ -495,7 +495,7 @@ static const struct regmap_config mrf24j40_long_regmap = {
> .pad_bits = 5,
> .write_flag_mask = MRF24J40_LONG_ACCESS,
> .read_flag_mask = MRF24J40_LONG_ACCESS,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .max_register = MRF24J40_LONG_NUMREGS,
> .writeable_reg = mrf24j40_long_reg_writeable,
> .readable_reg = mrf24j40_long_reg_readable,

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt