2024-01-31 15:49:56

by Andrew Lunn

Subject: Re: [PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init

On Mon, Jan 22, 2024 at 10:28:45PM +0100, Dimitri Fedrau wrote:
> mv88q2xxx_config_init calls genphy_c45_read_pma which is done by
> mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is
> also called by the PHY state machine. Let the PHY state machine handle
> the phydriver ops in their intendend way.
>
> Signed-off-by: Dimitri Fedrau <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2024-02-02 17:20:35

by Dimitri Fedrau

Subject: Re: [PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init

Am Wed, Jan 31, 2024 at 04:21:44PM +0100 schrieb Andrew Lunn:
> On Mon, Jan 22, 2024 at 10:28:45PM +0100, Dimitri Fedrau wrote:
> > mv88q2xxx_config_init calls genphy_c45_read_pma which is done by
> > mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is
> > also called by the PHY state machine. Let the PHY state machine handle
> > the phydriver ops in their intendend way.
> >
> > Signed-off-by: Dimitri Fedrau <[email protected]>
>
> Reviewed-by: Andrew Lunn <[email protected]>
>
Thanks, for reviewing. Is there a chance that you also have a look on
patch 13 of the series ? It relies on this patch.