2024-02-03 13:24:49

by Abhinav Jain

Subject: [PATCH] Task: Extra credit : LKMP Bug Fixing 2024 Spring : Documentation

Added a prototype for dget() to fix the warning

Signed-off-by: Abhinav Jain <[email protected]>
---
include/linux/dcache.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/include/linux/dcache.h b/include/linux/dcache.h
index 3da2f0545d5d..b082b48e7eb5 100644
--- a/include/linux/dcache.h
+++ b/include/linux/dcache.h
@@ -301,7 +301,7 @@ extern char *dentry_path(const struct dentry *, char *, int);
/* Allocation counts.. */

/**
- * dget, dget_dlock - get a reference to a dentry
+ * dget_dlock - get a reference to a dentry
* @dentry: dentry to get a reference to
*
* Given a dentry or %NULL pointer increment the reference count
@@ -315,6 +315,13 @@ static inline struct dentry *dget_dlock(struct dentry *dentry)
return dentry;
}

+/**
+ * dget - get a reference to a dentry
+ * @dentry: dentry to get a reference to
+ *
+ * Given a dentry or %NULL pointer increment the reference count
+ * unconditionally and return it.
+ */
static inline struct dentry *dget(struct dentry *dentry)
{
if (dentry)
--
2.25.1

2024-02-03 20:29:56

by Randy Dunlap

Subject: Re: [PATCH] Task: Extra credit : LKMP Bug Fixing 2024 Spring : Documentation

Hi--

On 2/3/24 05:07, Abhinav Jain wrote:
> Added a prototype for dget() to fix the warning
>
> Signed-off-by: Abhinav Jain <[email protected]>
> ---
> include/linux/dcache.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
> index 3da2f0545d5d..b082b48e7eb5 100644
> --- a/include/linux/dcache.h
> +++ b/include/linux/dcache.h
> @@ -301,7 +301,7 @@ extern char *dentry_path(const struct dentry *, char *, int);
> /* Allocation counts.. */
>
> /**
> - * dget, dget_dlock - get a reference to a dentry
> + * dget_dlock - get a reference to a dentry
> * @dentry: dentry to get a reference to
> *
> * Given a dentry or %NULL pointer increment the reference count
> @@ -315,6 +315,13 @@ static inline struct dentry *dget_dlock(struct dentry *dentry)
> return dentry;
> }
>
> +/**
> + * dget - get a reference to a dentry
> + * @dentry: dentry to get a reference to
> + *
> + * Given a dentry or %NULL pointer increment the reference count
> + * unconditionally and return it.
> + */
> static inline struct dentry *dget(struct dentry *dentry)
> {
> if (dentry)

The function documentation now makes it look like these functions do the
same thing, so why have both of them -- or am I misreading it?

Anyway, this problem is already fixed in the linux-next tree (more specifically
in the vfs tree).

Thanks.
--
#Randy