2024-02-03 16:26:08

by Amitesh Singh

Subject: [PATCH v3] leds: pca963x: Add power management support

This implements power management for pca9633 which enables
device sleep and resume on system-wide sleep/hibernation

Signed-off-by: Amitesh Singh <[email protected]>
---
drivers/leds/leds-pca963x.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
index 47223c850e4b..b53905da3592 100644
--- a/drivers/leds/leds-pca963x.c
+++ b/drivers/leds/leds-pca963x.c
@@ -39,6 +39,7 @@
#define PCA963X_LED_PWM 0x2 /* Controlled through PWM */
#define PCA963X_LED_GRP_PWM 0x3 /* Controlled through PWM/GRPPWM */

+#define PCA963X_MODE1_SLEEP 0x04 /* Normal mode or Low Power mode, oscillator off */
#define PCA963X_MODE2_OUTDRV 0x04 /* Open-drain or totem pole */
#define PCA963X_MODE2_INVRT 0x10 /* Normal or inverted direction */
#define PCA963X_MODE2_DMBLNK 0x20 /* Enable blinking */
@@ -380,6 +381,32 @@ static int pca963x_register_leds(struct i2c_client *client,
return ret;
}

+static int pca963x_suspend(struct device *dev)
+{
+ struct pca963x *chip = dev_get_drvdata(dev);
+ u8 reg;
+
+ reg = i2c_smbus_read_byte_data(chip->client, PCA963X_MODE1);
+ reg = reg | BIT(PCA963X_MODE1_SLEEP);
+ i2c_smbus_write_byte_data(chip->client, PCA963X_MODE1, reg);
+
+ return 0;
+}
+
+static int pca963x_resume(struct device *dev)
+{
+ struct pca963x *chip = dev_get_drvdata(dev);
+ u8 reg;
+
+ reg = i2c_smbus_read_byte_data(chip->client, PCA963X_MODE1);
+ reg = reg & ~BIT(PCA963X_MODE1_SLEEP);
+ i2c_smbus_write_byte_data(chip->client, PCA963X_MODE1, reg);
+
+ return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(pca963x_pm, pca963x_suspend, pca963x_resume);
+
static const struct of_device_id of_pca963x_match[] = {
{ .compatible = "nxp,pca9632", },
{ .compatible = "nxp,pca9633", },
@@ -430,6 +457,7 @@ static struct i2c_driver pca963x_driver = {
.driver = {
.name = "leds-pca963x",
.of_match_table = of_pca963x_match,
+ .pm = pm_sleep_ptr(&pca963x_pm)
},
.probe = pca963x_probe,
.id_table = pca963x_id,
--
2.43.0

2024-02-08 12:13:49

by Lee Jones

Subject: Re: (subset) [PATCH v3] leds: pca963x: Add power management support

On Sat, 03 Feb 2024 21:55:24 +0530, Amitesh Singh wrote:
> This implements power management for pca9633 which enables
> device sleep and resume on system-wide sleep/hibernation
>
>

Applied, thanks!

[1/1] leds: pca963x: Add power management support
commit: e684dcca3659a3f88945a2a5c6fe5a156d4b0178

--
Lee Jones [李琼斯]

2024-02-10 16:34:31

by Amitesh Singh

Subject: Re: (subset) [PATCH v3] leds: pca963x: Add power management support

On Thu, Feb 8, 2024 at 5:05 PM Lee Jones <[email protected]> wrote:
>
> On Sat, 03 Feb 2024 21:55:24 +0530, Amitesh Singh wrote:
> > This implements power management for pca9633 which enables
> > device sleep and resume on system-wide sleep/hibernation
> >
> >
>
> Applied, thanks!
>

Thanks for reviewing.

> [1/1] leds: pca963x: Add power management support
> commit: e684dcca3659a3f88945a2a5c6fe5a156d4b0178
>
> --
> Lee Jones [李琼斯]
>