2024-02-03 19:12:44

by Anton Bambura

[permalink] [raw]
Subject: [PATCH v2 1/6] arm64: dts: qcom: sc8180x-lenovo-flex-5g: fix GPU firmware path

Fix GPU firmware path so it uses model-specific directory.

Signed-off-by: Anton Bambura <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index 0c22f3efec20..49b740c54674 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -350,7 +350,7 @@ &gpu {

zap-shader {
memory-region = <&gpu_mem>;
- firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn";
+ firmware-name = "qcom/sc8180x/LENOVO/82AK/qcdxkmsuc8180.mbn";
};
};

--
2.42.0



2024-02-13 17:14:41

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: sc8180x-lenovo-flex-5g: fix GPU firmware path

On Sat, Feb 03, 2024 at 09:11:55PM +0200, Anton Bambura wrote:
> Fix GPU firmware path so it uses model-specific directory.
>
> Signed-off-by: Anton Bambura <[email protected]>
> Reviewed-by: Konrad Dybcio <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index 0c22f3efec20..49b740c54674 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -350,7 +350,7 @@ &gpu {
>
> zap-shader {
> memory-region = <&gpu_mem>;
> - firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn";
> + firmware-name = "qcom/sc8180x/LENOVO/82AK/qcdxkmsuc8180.mbn";

Where is the firmware located for this device? I couldn't find it in
linux-firmware [1].

- Mani

[1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qcom

> };
> };
>
> --
> 2.42.0
>
>

--
மணிவண்ணன் சதாசிவம்

2024-02-13 17:34:11

by Anton Bambura

[permalink] [raw]
Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: sc8180x-lenovo-flex-5g: fix GPU firmware path

February 13, 2024 at 7:14 PM, "Manivannan Sadhasivam" <[email protected]> wrote:



>
> On Sat, Feb 03, 2024 at 09:11:55PM +0200, Anton Bambura wrote:
>
> >
> > Fix GPU firmware path so it uses model-specific directory.
> >
> >
> >
> > Signed-off-by: Anton Bambura <[email protected]>
> >
> > Reviewed-by: Konrad Dybcio <[email protected]>
> >
> > ---
> >
> > arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
> >
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> > index 0c22f3efec20..49b740c54674 100644
> >
> > --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> > +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> > @@ -350,7 +350,7 @@ &gpu {
> >
> >
> >
> > zap-shader {
> >
> > memory-region = <&gpu_mem>;
> >
> > - firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn";
> >
> > + firmware-name = "qcom/sc8180x/LENOVO/82AK/qcdxkmsuc8180.mbn";
> >
>
> Where is the firmware located for this device? I couldn't find it in

NHLOS partition on the storage. I also maintain a package in postmarketOS

>
> linux-firmware [1].
>
> - Mani
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qcom
>
> >
> > };
> >
> > };
> >
> >
> >
> > --
> >
> > 2.42.0
> >
>
> --
>
> மணிவண்ணன் சதாசிவம்
>

2024-02-13 18:02:54

by Anton Bambura

[permalink] [raw]
Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: sc8180x-lenovo-flex-5g: fix GPU firmware path

February 13, 2024 at 7:51 PM, "Manivannan Sadhasivam" <[email protected]> wrote:



>
> On Tue, Feb 13, 2024 at 05:33:42PM +0000, [email protected] wrote:
>
> >
> > February 13, 2024 at 7:14 PM, "Manivannan Sadhasivam" <[email protected]> wrote:
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > On Sat, Feb 03, 2024 at 09:11:55PM +0200, Anton Bambura wrote:
> >
> >
> >
> > >
> >
> > > Fix GPU firmware path so it uses model-specific directory.
> >
> > >
> >
> > >
> >
> > >
> >
> > > Signed-off-by: Anton Bambura <[email protected]>
> >
> > >
> >
> > > Reviewed-by: Konrad Dybcio <[email protected]>
> >
> > >
> >
> > > ---
> >
> > >
> >
> > > arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
> >
> > >
> >
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > >
> >
> > >
> >
> > >
> >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> > >
> >
> > > index 0c22f3efec20..49b740c54674 100644
> >
> > >
> >
> > > --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> > >
> >
> > > +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> > >
> >
> > > @@ -350,7 +350,7 @@ &gpu {
> >
> > >
> >
> > >
> >
> > >
> >
> > > zap-shader {
> >
> > >
> >
> > > memory-region = <&gpu_mem>;
> >
> > >
> >
> > > - firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn";
> >
> > >
> >
> > > + firmware-name = "qcom/sc8180x/LENOVO/82AK/qcdxkmsuc8180.mbn";
> >
> > >
> >
> >
> >
> > Where is the firmware located for this device? I couldn't find it in
> >
> >
> >
> > NHLOS partition on the storage. I also maintain a package in postmarketOS
> >
>
> Could you point me to the package?

https://gitlab.com/jenneron/firmware-lenovo-yoga-5g
https://gitlab.com/postmarketOS/pmaports/-/blob/master/device/testing/firmware-lenovo-yoga-5g/APKBUILD

>
> - Mani
>
> --
>
> மணிவண்ணன் சதாசிவம்
>

2024-02-13 18:14:07

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: sc8180x-lenovo-flex-5g: fix GPU firmware path

On Tue, Feb 13, 2024 at 05:33:42PM +0000, [email protected] wrote:
> February 13, 2024 at 7:14 PM, "Manivannan Sadhasivam" <[email protected]> wrote:
>
>
>
> >
> > On Sat, Feb 03, 2024 at 09:11:55PM +0200, Anton Bambura wrote:
> >
> > >
> > > Fix GPU firmware path so it uses model-specific directory.
> > >
> > >
> > >
> > > Signed-off-by: Anton Bambura <[email protected]>
> > >
> > > Reviewed-by: Konrad Dybcio <[email protected]>
> > >
> > > ---
> > >
> > > arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
> > >
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> > >
> > > index 0c22f3efec20..49b740c54674 100644
> > >
> > > --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> > >
> > > +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> > >
> > > @@ -350,7 +350,7 @@ &gpu {
> > >
> > >
> > >
> > > zap-shader {
> > >
> > > memory-region = <&gpu_mem>;
> > >
> > > - firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn";
> > >
> > > + firmware-name = "qcom/sc8180x/LENOVO/82AK/qcdxkmsuc8180.mbn";
> > >
> >
> > Where is the firmware located for this device? I couldn't find it in
>
> NHLOS partition on the storage. I also maintain a package in postmarketOS
>

Could you point me to the package?

- Mani

--
மணிவண்ணன் சதாசிவம்