Now that the driver core can properly handle constant struct bus_type,
move the w1_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/w1/w1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 5353cbd75126..afb1cc4606c5 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -167,7 +167,7 @@ static struct w1_family w1_default_family = {
static int w1_uevent(const struct device *dev, struct kobj_uevent_env *env);
-static struct bus_type w1_bus_type = {
+static const struct bus_type w1_bus_type = {
.name = "w1",
.uevent = w1_uevent,
};
---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-w1-e46a15c8237f
Best regards,
--
Ricardo B. Marliere <[email protected]>
On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
Does "Now" means some dependency on other patches?
> move the w1_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
Best regards,
Krzysztof
On 5 Feb 08:34, Krzysztof Kozlowski wrote:
> On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
>
> Does "Now" means some dependency on other patches?
Hi Krzysztof!
Please check:
https://lore.kernel.org/all/[email protected]/
You can apply as is.
Thanks for reviewing,
- Ricardo
>
> > move the w1_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
>
> Best regards,
> Krzysztof
>
On Sun, 04 Feb 2024 17:55:22 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the w1_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
>
Applied, thanks!
[1/1] w1: make w1_bus_type const
https://git.kernel.org/krzk/linux-w1/c/8650843ca42a7fd8255f4dcddbaa20393e01fe11
Best regards,
--
Krzysztof Kozlowski <[email protected]>
On Sun, Feb 04, 2024 at 05:55:22PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the w1_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---
> drivers/w1/w1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Greg Kroah-Hartman <[email protected]>
On Mon, Feb 05, 2024 at 09:08:20AM -0300, Ricardo B. Marliere wrote:
> On 5 Feb 08:34, Krzysztof Kozlowski wrote:
> > On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> > > Now that the driver core can properly handle constant struct bus_type,
> >
> > Does "Now" means some dependency on other patches?
>
> Hi Krzysztof!
>
> Please check:
> https://lore.kernel.org/all/[email protected]/
Sorry, no, that is for device_type, not bus_type. bus_type didn't
become able to be const until 6.4 or so.
thanks,
greg k-h
On 5 Feb 19:08, Greg Kroah-Hartman wrote:
> On Mon, Feb 05, 2024 at 09:08:20AM -0300, Ricardo B. Marliere wrote:
> > On 5 Feb 08:34, Krzysztof Kozlowski wrote:
> > > On 04/02/2024 21:55, Ricardo B. Marliere wrote:
> > > > Now that the driver core can properly handle constant struct bus_type,
> > >
> > > Does "Now" means some dependency on other patches?
> >
> > Hi Krzysztof!
> >
> > Please check:
> > https://lore.kernel.org/all/[email protected]/
>
> Sorry, no, that is for device_type, not bus_type. bus_type didn't
> become able to be const until 6.4 or so.
Ah yes, sorry. The correct link should be:
https://lore.kernel.org/all/[email protected]/
>
> thanks,
>
> greg k-h