2023-10-07 07:07:08

by Mark-PK Tsai (蔡沛剛)

Subject: [PATCH] zram: use copy_page for full page copy

Some architectures, such as arm, have implemented
optimized copy_page for full page copying.

Replace the full page memcpy with copy_page to
take advantage of the optimization.

Signed-off-by: Mark-PK Tsai <[email protected]>
---
drivers/block/zram/zram_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index d77d3664ca08..58700dd73d1d 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1338,7 +1338,7 @@ static int zram_read_from_zspool(struct zram *zram, struct page *page,
src = zs_map_object(zram->mem_pool, handle, ZS_MM_RO);
if (size == PAGE_SIZE) {
dst = kmap_atomic(page);
- memcpy(dst, src, PAGE_SIZE);
+ copy_page(dst, src);
kunmap_atomic(dst);
ret = 0;
} else {
--
2.18.0

2023-10-08 04:39:13

by Sergey Senozhatsky

Subject: Re: [PATCH] zram: use copy_page for full page copy

On (23/10/07 15:05), Mark-PK Tsai wrote:
>
> Some architectures, such as arm, have implemented
> optimized copy_page for full page copying.
>
> Replace the full page memcpy with copy_page to
> take advantage of the optimization.
>
> Signed-off-by: Mark-PK Tsai <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>

2024-02-05 06:44:02

by Mark-PK Tsai (蔡沛剛)

Subject: Re: [PATCH] zram: use copy_page for full page copy

On Sun, 2023-10-08 at 13:38 +0900, Sergey Senozhatsky wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On (23/10/07 15:05), Mark-PK Tsai wrote:
> >
> > Some architectures, such as arm, have implemented
> > optimized copy_page for full page copying.
> >
> > Replace the full page memcpy with copy_page to
> > take advantage of the optimization.
> >
> > Signed-off-by: Mark-PK Tsai <[email protected]>
>
> Reviewed-by: Sergey Senozhatsky <[email protected]>

I guess this patch may have been overlooked.
Could someone please help to review it?

Thanks,
Mark

2024-02-05 06:48:42

by Sergey Senozhatsky

Subject: Re: [PATCH] zram: use copy_page for full page copy

On (24/02/05 06:43), Mark-PK Tsai (蔡沛剛) wrote:
> On Sun, 2023-10-08 at 13:38 +0900, Sergey Senozhatsky wrote:
> >
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> > On (23/10/07 15:05), Mark-PK Tsai wrote:
> > >
> > > Some architectures, such as arm, have implemented
> > > optimized copy_page for full page copying.
> > >
> > > Replace the full page memcpy with copy_page to
> > > take advantage of the optimization.
> > >
> > > Signed-off-by: Mark-PK Tsai <[email protected]>
> >
> > Reviewed-by: Sergey Senozhatsky <[email protected]>
>
> I guess this patch may have been overlooked.
> Could someone please help to review it?

Oh, yes. Let me take care of that.

2024-02-05 06:50:41

by Sergey Senozhatsky

Subject: Re: [PATCH] zram: use copy_page for full page copy

Cc-ing Andrew on this

On (23/10/07 15:05), Mark-PK Tsai wrote:
> Some architectures, such as arm, have implemented
> optimized copy_page for full page copying.
>
> Replace the full page memcpy with copy_page to
> take advantage of the optimization.
>
> Signed-off-by: Mark-PK Tsai <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>

> ---
> drivers/block/zram/zram_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index d77d3664ca08..58700dd73d1d 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1338,7 +1338,7 @@ static int zram_read_from_zspool(struct zram *zram, struct page *page,
> src = zs_map_object(zram->mem_pool, handle, ZS_MM_RO);
> if (size == PAGE_SIZE) {
> dst = kmap_atomic(page);
> - memcpy(dst, src, PAGE_SIZE);
> + copy_page(dst, src);
> kunmap_atomic(dst);
> ret = 0;
> } else {
> --
> 2.18.0