On Mon, 22 Jan 2024 22:28:33 +0100 Dimitri Fedrau wrote:
> Changes in V5:
> - add missing statics for mv88q222x_revb0_init_seq0 and
> mv88q222x_revb0_init_seq1
> - fix typo in commit message: autonegotiation
> - fix ordering of Signed-off-by and Reviewed-by in commit messages
> - add interrupt support for link detection
> - add suspend / resume ops
> - add support for internal temperature sensor
> - add cable test support
> - call .soft_reset in mv88q2xxx_config_aneg, this makes
> mv88q2xxx_config_aneg compatible for Marvell88Q222x devices and
> remove mv88q222x_config_aneg which is then just duplicated code
> - cleanup mv88q2xxx_config_init and make it compatible with
> Marvell88Q222x devices
> - move parts from mv88q222x_config_init to mv88q2xxx_config_init
> that are applicable for all Marvell88Q2xxx devices.
PHY maintainers - could anyone take a look at these patches?
[...]
Probably late, but there are parts of the code which are based on the
sample code provided by Marvell. The sample code is licensed under BSD
2 Clause. Should I change the license in the driver to dual license ?
Best regards,
Dimitri
On Fri, Feb 02, 2024 at 07:30:29PM +0100, Dimitri Fedrau wrote:
> [...]
>
> Probably late, but there are parts of the code which are based on the
> sample code provided by Marvell. The sample code is licensed under BSD
> 2 Clause. Should I change the license in the driver to dual license ?
IANAL
You can take BSD code and release it with a GPL license. But it would
be better to indicate it is derived from BSD code. Either make it dual
license, or add a comment about the origin of the code.
Andrew
Am Sat, Feb 03, 2024 at 05:07:13PM +0100 schrieb Andrew Lunn:
> On Fri, Feb 02, 2024 at 07:30:29PM +0100, Dimitri Fedrau wrote:
> > [...]
> >
> > Probably late, but there are parts of the code which are based on the
> > sample code provided by Marvell. The sample code is licensed under BSD
> > 2 Clause. Should I change the license in the driver to dual license ?
>
> IANAL
>
> You can take BSD code and release it with a GPL license. But it would
> be better to indicate it is derived from BSD code. Either make it dual
> license, or add a comment about the origin of the code.
>
Is there a reason why the "MODULE_AUTHOR" is not in the driver and it's
also missing in marvell-88x2222.c. I also don't see any copyright
information. I'm just curious, not seeking for any legal advice. :) I
just have to get this figured out to stay out of trouble.
Dimitri