2024-02-05 14:22:52

by Théo Lebrun

[permalink] [raw]
Subject: [PATCH v2 0/5] spi: cadence-qspi: Fix runtime PM and system-wide suspend

Hi,

This fixes runtime PM and system-wide suspend for the cadence-qspi
driver. Seeing how runtime PM and autosuspend are enabled by default, I
believe this affects all users of the driver.

The initial change has been split into three commits and a fourth commit
is added to add system-wide suspend/resume callbacks.

The MIPS platform at hand, used for debugging and testing, is currently
not supported by the driver. It is the Mobileye EyeQ5 [0]. No code
changes are required for support, only a new compatible and appropriate
match data + flags. That will come later, with some performance-related
patches.

TODO: changelog below

Thanks all,
Théo

[0]: https://lore.kernel.org/lkml/[email protected]/

Signed-off-by: Théo Lebrun <[email protected]>
---
Changes in v2:
- EDxxITME: describe what is new in this series revision.
- EDxxITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Théo Lebrun (5):
spi: cadence-qspi: put runtime in runtime PM hooks names
spi: cadence-qspi: fix pointer reference in runtime PM hooks
spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks
spi: cadence-qspi: add system-wide suspend and resume callbacks
WIP: spi: cadence-qspi: add debug logs for PM

drivers/spi/spi-cadence-quadspi.c | 45 ++++++++++++++++++++++++++++-----------
1 file changed, 33 insertions(+), 12 deletions(-)
---
base-commit: 13acce918af915278e49980a3038df31845dbf39
change-id: 20240202-cdns-qspi-pm-fix-29600cc6d7bf

Best regards,
--
Théo Lebrun <[email protected]>



2024-02-05 15:00:57

by Théo Lebrun

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] spi: cadence-qspi: Fix runtime PM and system-wide suspend

Hi Dhruva,

On Mon Feb 5, 2024 at 3:44 PM CET, Dhruva Gole wrote:
> On Feb 05, 2024 at 15:22:34 +0100, Théo Lebrun wrote:
> > TODO: changelog below
>
> Accidental "git-sent" email? ;)

Indeed. :-) I wanted to share the series with a colleague for testing on
J7200 and messed up.

Looking forward to your review and testing on the V2.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2024-02-05 15:14:33

by Dhruva Gole

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] spi: cadence-qspi: Fix runtime PM and system-wide suspend

On Feb 05, 2024 at 15:22:34 +0100, Th?o Lebrun wrote:
> Hi,
>
> This fixes runtime PM and system-wide suspend for the cadence-qspi
> driver. Seeing how runtime PM and autosuspend are enabled by default, I
> believe this affects all users of the driver.
>
> The initial change has been split into three commits and a fourth commit
> is added to add system-wide suspend/resume callbacks.
>
> The MIPS platform at hand, used for debugging and testing, is currently
> not supported by the driver. It is the Mobileye EyeQ5 [0]. No code
> changes are required for support, only a new compatible and appropriate
> match data + flags. That will come later, with some performance-related
> patches.
>
> TODO: changelog below

Accidental "git-sent" email? ;)

>
> Thanks all,
> Th?o
>
> [0]: https://lore.kernel.org/lkml/[email protected]/
>
> Signed-off-by: Th?o Lebrun <[email protected]>
> ---
> Changes in v2:
> - EDxxITME: describe what is new in this series revision.
> - EDxxITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/[email protected]
>
> ---
> Th?o Lebrun (5):
> spi: cadence-qspi: put runtime in runtime PM hooks names
> spi: cadence-qspi: fix pointer reference in runtime PM hooks
> spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks
> spi: cadence-qspi: add system-wide suspend and resume callbacks
> WIP: spi: cadence-qspi: add debug logs for PM

I don't seem to have recieved any of these FYI

>
> drivers/spi/spi-cadence-quadspi.c | 45 ++++++++++++++++++++++++++++-----------
> 1 file changed, 33 insertions(+), 12 deletions(-)
> ---
> base-commit: 13acce918af915278e49980a3038df31845dbf39
> change-id: 20240202-cdns-qspi-pm-fix-29600cc6d7bf
>
> Best regards,
> --
> Th?o Lebrun <[email protected]>
>

--
Best regards,
Dhruva Gole <[email protected]>