The mtd binding is always $ref'ed by other bindings, default selector
should be from other binding files which ref'ed it. Now, "$nodename" in
mtd.yaml turns into a "select" automatically such that a few binding check
issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
rules in folder sram/*)
To avoid the automatically created "select" in mtd.yaml, adding:
select: false
Suggested-by: Bjorn Andersson <[email protected]>
Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
Signed-off-by: Zhenhua Huang <[email protected]>
---
Hi Bjorn,
As the idea is from your comment, I added "Suggested-by" you.
Please tell me if that's not suitable. Thanks.
Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
index f322290..ee442ec 100644
--- a/Documentation/devicetree/bindings/mtd/mtd.yaml
+++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
@@ -10,6 +10,8 @@ maintainers:
- Miquel Raynal <[email protected]>
- Richard Weinberger <[email protected]>
+select: false
+
properties:
$nodename:
pattern: "^(flash|.*sram|nand)(@.*)?$"
--
2.7.4
On Wed, Jan 10, 2024 at 07:21:45PM +0800, Zhenhua Huang wrote:
> The mtd binding is always $ref'ed by other bindings, default selector
> should be from other binding files which ref'ed it. Now, "$nodename" in
> mtd.yaml turns into a "select" automatically such that a few binding check
> issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> rules in folder sram/*)
>
> To avoid the automatically created "select" in mtd.yaml, adding:
>
> select: false
>
> Suggested-by: Bjorn Andersson <[email protected]>
> Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> Signed-off-by: Zhenhua Huang <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
> ---
> Hi Bjorn,
>
> As the idea is from your comment, I added "Suggested-by" you.
> Please tell me if that's not suitable. Thanks.
I appreciate that, thank you.
Regards,
Bjorn
>
> Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
> index f322290..ee442ec 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
> @@ -10,6 +10,8 @@ maintainers:
> - Miquel Raynal <[email protected]>
> - Richard Weinberger <[email protected]>
>
> +select: false
> +
> properties:
> $nodename:
> pattern: "^(flash|.*sram|nand)(@.*)?$"
> --
> 2.7.4
>
On Wed, 10 Jan 2024 19:21:45 +0800, Zhenhua Huang wrote:
> The mtd binding is always $ref'ed by other bindings, default selector
> should be from other binding files which ref'ed it. Now, "$nodename" in
> mtd.yaml turns into a "select" automatically such that a few binding check
> issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> rules in folder sram/*)
>
> To avoid the automatically created "select" in mtd.yaml, adding:
>
> select: false
>
> Suggested-by: Bjorn Andersson <[email protected]>
> Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> Signed-off-by: Zhenhua Huang <[email protected]>
> ---
> Hi Bjorn,
>
> As the idea is from your comment, I added "Suggested-by" you.
> Please tell me if that's not suitable. Thanks.
>
> Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
Hi,
[email protected] wrote on Tue, 16 Jan 2024 11:10:05 -0600:
> On Wed, 10 Jan 2024 19:21:45 +0800, Zhenhua Huang wrote:
> > The mtd binding is always $ref'ed by other bindings, default selector
> > should be from other binding files which ref'ed it. Now, "$nodename" in
> > mtd.yaml turns into a "select" automatically such that a few binding check
> > issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> > rules in folder sram/*)
> >
> > To avoid the automatically created "select" in mtd.yaml, adding:
> >
> > select: false
> >
> > Suggested-by: Bjorn Andersson <[email protected]>
> > Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> > Signed-off-by: Zhenhua Huang <[email protected]>
> > ---
> > Hi Bjorn,
> >
> > As the idea is from your comment, I added "Suggested-by" you.
> > Please tell me if that's not suitable. Thanks.
> >
> > Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Acked-by: Rob Herring <[email protected]>
Applied to mtd/next, thanks!
Miquèl