2024-02-05 21:47:07

by Andrew Davis

Subject: [PATCH v2 00/19] Remove pm_power_off use in drivers/power/reset

Hello all,

Use of pm_power_off is considered legacy and should be replaced with
register_sys_off*(). Same for register_restart_handler(). Do this
for the drivers/power/reset subsystem for all trivial cases.

Thanks,
Andrew

Changes for v2:
- Fix sparse warning in 7/19 and 10/19
- Add new patch fixing an already existing sparse warning (3/19)
- Rebase on v6.8-rc3

Andrew Davis (19):
power: reset: atc260x-poweroff: Use
devm_register_sys_off_handler(RESTART)
power: reset: atc260x-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: xgene-reboot: Use devm_platform_ioremap_resource()
helper
power: reset: xgene-reboot: Use devm_register_sys_off_handler(RESTART)
power: reset: tps65086-restart: Use
devm_register_sys_off_handler(RESTART)
power: reset: tps65086-restart: Remove unneeded device data struct
power: reset: brcm-kona-reset: Use
devm_register_sys_off_handler(RESTART)
power: reset: axxia-reset: Use devm_register_sys_off_handler(RESTART)
power: reset: rmobile-reset: Use devm_platform_ioremap_resource()
helper
power: reset: rmobile-reset: Use
devm_register_sys_off_handler(RESTART)
power: reset: mt6323-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: msm-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: msm-poweroff: Use devm_register_sys_off_handler(RESTART)
power: reset: regulator-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: as3722-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: gemini-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: restart-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)
power: reset: syscon-poweroff: Move device data into a struct
power: reset: syscon-poweroff: Use
devm_register_sys_off_handler(POWER_OFF)

drivers/power/reset/as3722-poweroff.c | 30 ++++-------
drivers/power/reset/atc260x-poweroff.c | 55 ++++++++------------
drivers/power/reset/axxia-reset.c | 16 +++---
drivers/power/reset/brcm-kona-reset.c | 11 ++--
drivers/power/reset/gemini-poweroff.c | 16 +++---
drivers/power/reset/msm-poweroff.c | 25 ++++-----
drivers/power/reset/mt6323-poweroff.c | 28 +++++-----
drivers/power/reset/regulator-poweroff.c | 36 +++++--------
drivers/power/reset/restart-poweroff.c | 25 +++------
drivers/power/reset/rmobile-reset.c | 35 ++++---------
drivers/power/reset/syscon-poweroff.c | 66 ++++++++++++------------
drivers/power/reset/tps65086-restart.c | 58 ++++-----------------
drivers/power/reset/xgene-reboot.c | 21 +++-----
13 files changed, 154 insertions(+), 268 deletions(-)

--
2.39.2

2024-02-05 21:47:49

by Andrew Davis

Subject: [PATCH v2 09/19] power: reset: rmobile-reset: Use devm_platform_ioremap_resource() helper

Use device life-cycle managed ioremap function to simplify probe and
exit paths.

Signed-off-by: Andrew Davis <[email protected]>
---
drivers/power/reset/rmobile-reset.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/power/reset/rmobile-reset.c b/drivers/power/reset/rmobile-reset.c
index 5df9b41c68c79..29c17ed2d4de9 100644
--- a/drivers/power/reset/rmobile-reset.c
+++ b/drivers/power/reset/rmobile-reset.c
@@ -41,28 +41,23 @@ static int rmobile_reset_probe(struct platform_device *pdev)
{
int error;

- sysc_base2 = of_iomap(pdev->dev.of_node, 1);
- if (!sysc_base2)
- return -ENODEV;
+ sysc_base2 = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(sysc_base2))
+ return PTR_ERR(sysc_base2);

error = register_restart_handler(&rmobile_reset_nb);
if (error) {
dev_err(&pdev->dev,
"cannot register restart handler (err=%d)\n", error);
- goto fail_unmap;
+ return error;
}

return 0;
-
-fail_unmap:
- iounmap(sysc_base2);
- return error;
}

static void rmobile_reset_remove(struct platform_device *pdev)
{
unregister_restart_handler(&rmobile_reset_nb);
- iounmap(sysc_base2);
}

static const struct of_device_id rmobile_reset_of_match[] = {
--
2.39.2