2024-02-06 16:03:37

by Henrik Grimler

[permalink] [raw]
Subject: [PATCH v2] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node

By using brcm/brcmfmac4354-sdio.bin from linux-firmware together with
nvram.txt from vendor firmware wifi works well on the chagall-wifi and
klimt-lte.

Signed-off-by: Henrik Grimler <[email protected]>
---
Describe wifi node for exynos5420-chagall-wifi and
exynos5420-klimt-wifi, and decrease available memory.
---
Changes in v2:
- Drop patch 1 and 3 (the latter was applied)
- Fixup patch 2 so it applies cleanly after dropping patch 1
- Link to v1: https://lore.kernel.org/r/[email protected]
---

Changes since v1:
- Fix conflicts after dropping patch 1
---
.../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 32 ++++++++++++++++++++++
1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
index 3532f1e8e902..246040967082 100644
--- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
@@ -30,6 +30,7 @@ / {

aliases {
mmc0 = &mmc_0;
+ mmc1 = &mmc_1;
mmc2 = &mmc_2;
};

@@ -87,6 +88,13 @@ key-volume-down {
linux,code = <KEY_VOLUMEDOWN>;
};
};
+
+ mmc1_pwrseq: pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpy7 7 GPIO_ACTIVE_LOW>;
+ clocks = <&s2mps11_osc S2MPS11_CLK_BT>;
+ clock-names = "ext_clock";
+ };
};

&cci {
@@ -620,6 +628,25 @@ &mmc_0 {
vqmmc-supply = <&ldo3_reg>;
};

+/* WiFi */
+&mmc_1 {
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cap-sdio-irq;
+ card-detect-delay = <200>;
+ keep-power-in-suspend;
+ mmc-pwrseq = <&mmc1_pwrseq>;
+ non-removable;
+ pinctrl-0 = <&sd1_clk>, <&sd1_cmd>, <&sd1_int>, <&sd1_bus1>,
+ <&sd1_bus4>, <&wifi_en>;
+ pinctrl-names = "default";
+ vqmmc-supply = <&ldo2_reg>;
+ samsung,dw-mshc-ciu-div = <1>;
+ samsung,dw-mshc-ddr-timing = <0 2>;
+ samsung,dw-mshc-sdr-timing = <0 1>;
+ status = "okay";
+};
+
/* External sdcard */
&mmc_2 {
status = "okay";
@@ -649,6 +676,11 @@ s2mps11_irq: s2mps11-irq-pins {
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
};
+
+ wifi_en: wifi-en-pins {
+ samsung,pins = "gpy7-7";
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+ };
};

&rtc {

---
base-commit: 9a5dbb835fd396c78da34b26ee91db6d529d096d
change-id: 20231210-galaxy-tab-s-cleanup-14da98b23606

Best regards,
--
Henrik Grimler <[email protected]>



2024-02-07 15:52:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node


On Tue, 06 Feb 2024 17:02:27 +0100, Henrik Grimler wrote:
> By using brcm/brcmfmac4354-sdio.bin from linux-firmware together with
> nvram.txt from vendor firmware wifi works well on the chagall-wifi and
> klimt-lte.
>
>

Applied, thanks!

[1/1] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node
https://git.kernel.org/krzk/linux/c/60f1164e21cc04666d23b63e1153af74e7a5650d

Best regards,
--
Krzysztof Kozlowski <[email protected]>