2024-02-05 12:59:28

by Markus Elfring

Subject: [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 13:43:14 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/net/ethernet/engleder/tsnep_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
index eb64118f5b18..498c4d47e0fa 100644
--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -2564,8 +2564,7 @@ static int tsnep_probe(struct platform_device *pdev)
mutex_init(&adapter->rxnfc_lock);
INIT_LIST_HEAD(&adapter->rxnfc_rules);

- io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- adapter->addr = devm_ioremap_resource(&pdev->dev, io);
+ adapter->addr = devm_platform_get_and_ioremap_resource(pdev, 0, &io);
if (IS_ERR(adapter->addr))
return PTR_ERR(adapter->addr);
netdev->mem_start = io->start;
--
2.43.0

2024-02-05 22:08:59

by Gerhard Engleder

Subject: Re: [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe()

On 05.02.24 13:54, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Mon, 5 Feb 2024 13:43:14 +0100
>
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Tested-by: Gerhard Engleder <[email protected]>

2024-02-07 19:42:01

by Jakub Kicinski

Subject: Re: [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe()

On Mon, 5 Feb 2024 13:54:24 +0100 Markus Elfring wrote:
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

applied, thanks!
--
pw-bot: accept