2024-02-07 16:13:41

by Randy Dunlap

Subject: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

When VIDEO is not set, there is a build error. Fix that by selecting
VIDEO for PS3_PS3AV.

ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!

Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
Cc: Michael Ellerman <[email protected]>
Cc: Nicholas Piggin <[email protected]>
Cc: Christophe Leroy <[email protected]>
Cc: Aneesh Kumar K.V <[email protected]>
Cc: Naveen N. Rao <[email protected]>
Cc: [email protected]
Cc: Thomas Zimmermann <[email protected]>
Cc: Geoff Levand <[email protected]>
Acked-by: Geoff Levand <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Randy Dunlap <[email protected]>
---
v2: add Geoff's Ack;
add second Fixes: tag and more Cc:s (Thomas)

arch/powerpc/platforms/ps3/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
--- a/arch/powerpc/platforms/ps3/Kconfig
+++ b/arch/powerpc/platforms/ps3/Kconfig
@@ -67,6 +67,7 @@ config PS3_VUART
config PS3_PS3AV
depends on PPC_PS3
tristate "PS3 AV settings driver" if PS3_ADVANCED
+ select VIDEO
select PS3_VUART
default y
help

2024-02-07 16:37:01

by Thomas Zimmermann

Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

Am 07.02.24 um 17:13 schrieb Randy Dunlap:
> When VIDEO is not set, there is a build error. Fix that by selecting
> VIDEO for PS3_PS3AV.
>
> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>
> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
> Cc: Michael Ellerman <[email protected]>
> Cc: Nicholas Piggin <[email protected]>
> Cc: Christophe Leroy <[email protected]>
> Cc: Aneesh Kumar K.V <[email protected]>
> Cc: Naveen N. Rao <[email protected]>
> Cc: [email protected]
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Geoff Levand <[email protected]>
> Acked-by: Geoff Levand <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Randy Dunlap <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

> ---
> v2: add Geoff's Ack;
> add second Fixes: tag and more Cc:s (Thomas)
>
> arch/powerpc/platforms/ps3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
> --- a/arch/powerpc/platforms/ps3/Kconfig
> +++ b/arch/powerpc/platforms/ps3/Kconfig
> @@ -67,6 +67,7 @@ config PS3_VUART
> config PS3_PS3AV
> depends on PPC_PS3
> tristate "PS3 AV settings driver" if PS3_ADVANCED
> + select VIDEO
> select PS3_VUART
> default y
> help

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

2024-02-09 05:15:30

by Michael Ellerman

Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

Thomas Zimmermann <[email protected]> writes:
> Am 07.02.24 um 17:13 schrieb Randy Dunlap:
>> When VIDEO is not set, there is a build error. Fix that by selecting
>> VIDEO for PS3_PS3AV.
>>
>> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>>
>> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
>> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
>> Cc: Michael Ellerman <[email protected]>
>> Cc: Nicholas Piggin <[email protected]>
>> Cc: Christophe Leroy <[email protected]>
>> Cc: Aneesh Kumar K.V <[email protected]>
>> Cc: Naveen N. Rao <[email protected]>
>> Cc: [email protected]
>> Cc: Thomas Zimmermann <[email protected]>
>> Cc: Geoff Levand <[email protected]>
>> Acked-by: Geoff Levand <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Randy Dunlap <[email protected]>
>
> Reviewed-by: Thomas Zimmermann <[email protected]>

Can you take it via whatever tree the CONFIG_VIDEO patch is in?

Acked-by: Michael Ellerman <[email protected]>

cheers

2024-02-09 20:24:25

by Thomas Zimmermann

Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

Hi

Am 09.02.24 um 06:15 schrieb Michael Ellerman:
> Thomas Zimmermann <[email protected]> writes:
>> Am 07.02.24 um 17:13 schrieb Randy Dunlap:
>>> When VIDEO is not set, there is a build error. Fix that by selecting
>>> VIDEO for PS3_PS3AV.
>>>
>>> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>>>
>>> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
>>> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
>>> Cc: Michael Ellerman <[email protected]>
>>> Cc: Nicholas Piggin <[email protected]>
>>> Cc: Christophe Leroy <[email protected]>
>>> Cc: Aneesh Kumar K.V <[email protected]>
>>> Cc: Naveen N. Rao <[email protected]>
>>> Cc: [email protected]
>>> Cc: Thomas Zimmermann <[email protected]>
>>> Cc: Geoff Levand <[email protected]>
>>> Acked-by: Geoff Levand <[email protected]>
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Signed-off-by: Randy Dunlap <[email protected]>
>> Reviewed-by: Thomas Zimmermann <[email protected]>
> Can you take it via whatever tree the CONFIG_VIDEO patch is in?

The patch is now in drm-misc-next.

Best regards
Thomas

>
> Acked-by: Michael Ellerman <[email protected]>
>
> cheers

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)