2024-02-08 12:22:12

by Manuel Traut

Subject: [PATCH] ARM: dts: imx6ul: Set macaddress location in ocotp

If a bootloader does not configure the MAC address, devices come up with
a random MAC at the moment.

ocotp provides registers for storing the mac-address.
Configure those for i.MX6UL and i.MX6ULL allows net/core to retrieve it from
there.

Signed-off-by: Manuel Traut <[email protected]>
---
arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
index a27a7554c2e7..e5e8bf814f77 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
@@ -538,6 +538,8 @@ fec2: ethernet@20b4000 {
fsl,num-rx-queues = <1>;
fsl,stop-mode = <&gpr 0x10 4>;
fsl,magic-packet;
+ nvmem-cells = <&fec2_mac_addr>;
+ nvmem-cell-names = "mac-address";
status = "disabled";
};

@@ -897,6 +899,8 @@ fec1: ethernet@2188000 {
fsl,num-rx-queues = <1>;
fsl,stop-mode = <&gpr 0x10 3>;
fsl,magic-packet;
+ nvmem-cells = <&fec1_mac_addr>;
+ nvmem-cell-names = "mac-address";
status = "disabled";
};

@@ -1004,6 +1008,14 @@ tempmon_temp_grade: temp-grade@20 {
cpu_speed_grade: speed-grade@10 {
reg = <0x10 4>;
};
+ fec1_mac_addr: mac-addr@88 {
+ reg = <0x88 6>;
+ };
+
+ fec2_mac_addr: mac-addr@8e {
+ reg = <0x8e 6>;
+ };
+
};

csi: csi@21c4000 {
--
2.43.0

2024-02-23 23:33:43

by Shawn Guo

Subject: Re: [PATCH] ARM: dts: imx6ul: Set macaddress location in ocotp

On Thu, Feb 08, 2024 at 01:19:59PM +0100, Manuel Traut wrote:
> If a bootloader does not configure the MAC address, devices come up with
> a random MAC at the moment.
>
> ocotp provides registers for storing the mac-address.
> Configure those for i.MX6UL and i.MX6ULL allows net/core to retrieve it from
> there.
>
> Signed-off-by: Manuel Traut <[email protected]>
> ---
> arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> index a27a7554c2e7..e5e8bf814f77 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> @@ -538,6 +538,8 @@ fec2: ethernet@20b4000 {
> fsl,num-rx-queues = <1>;
> fsl,stop-mode = <&gpr 0x10 4>;
> fsl,magic-packet;
> + nvmem-cells = <&fec2_mac_addr>;
> + nvmem-cell-names = "mac-address";
> status = "disabled";
> };
>
> @@ -897,6 +899,8 @@ fec1: ethernet@2188000 {
> fsl,num-rx-queues = <1>;
> fsl,stop-mode = <&gpr 0x10 3>;
> fsl,magic-packet;
> + nvmem-cells = <&fec1_mac_addr>;
> + nvmem-cell-names = "mac-address";
> status = "disabled";
> };
>
> @@ -1004,6 +1008,14 @@ tempmon_temp_grade: temp-grade@20 {
> cpu_speed_grade: speed-grade@10 {
> reg = <0x10 4>;
> };

Have a newline between nodes.

> + fec1_mac_addr: mac-addr@88 {
> + reg = <0x88 6>;
> + };
> +
> + fec2_mac_addr: mac-addr@8e {
> + reg = <0x8e 6>;
> + };
> +

Dropped this one.

I fixed them up and applied the patch.

Shawn

> };
>
> csi: csi@21c4000 {
> --
> 2.43.0
>